Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] @prizm-ui/components - prizm-scroll-controls - visibility не корректно работает #780

Closed
1 of 9 tasks
stepandr opened this issue Oct 4, 2023 · 8 comments · Fixed by #1233
Closed
1 of 9 tasks

[BUG] @prizm-ui/components - prizm-scroll-controls - visibility не корректно работает #780

stepandr opened this issue Oct 4, 2023 · 8 comments · Fixed by #1233
Assignees
@ZurabDev
Labels
extra Not planed initially for sprint need_more_information priority:urgently "Tag: priority:urgently — Marks tasks or issues that require immediate attention and action. These a source:requested The tag indicates that the information or action being discussed was initiate type:bug Something isn't working
Milestone
3.9.0

Comments

@stepandr
Copy link
Contributor

stepandr commented Oct 4, 2023

Библиотека

Выберите нужное отметив галочку [x]

  • @prizm-ui/core
  • @prizm-ui/components
  • @prizm-ui/install
  • @prizm-ui/icons
  • @prizm-ui/flag-icons
  • @prizm-ui/theme
  • @prizm-ui/charts
  • @prizm-ui/ast
  • @prizm-ui/nx-plugin

Компонент

Название компонента или группы компонентов

Версия

Операционная ситема:

Windows 10, etc

Браузер:

Версия 117.0.5938.150 (Официальная сборка), (64 бит)

NodeJS:

➜ node --version
v16.13.0

Dependencies:

➜ npm ls @prizm-ui/components

@prizm-ui/components 2.1.8

➜ npm ls @angular/core

@prizm-ui/[email protected]
├─┬ @angular/[email protected]
│ └── @angular/[email protected] deduped
├─┬ @angular/[email protected]
│ └── @angular/[email protected] deduped
├─┬ @angular/[email protected]
│ └── @angular/[email protected] deduped
├── @angular/[email protected]
├─┬ @angular/[email protected]
│ └── @angular/[email protected] deduped
├─┬ @angular/[email protected]
│ └── @angular/[email protected] deduped
├─┬ @angular/[email protected]
│ └── @angular/[email protected] deduped
├─┬ @angular/[email protected]
│ └── @angular/[email protected] deduped
├─┬ @storybook/[email protected]
│ └── @angular/[email protected] deduped
├─┬ [email protected]
│ └── @angular/[email protected] deduped
└─┬ [email protected]
  └── @angular/[email protected] deduped

Проект в котором используется Prizm

  • Везде

Скрин / Видео проблемы

https://disk.yandex.ru/i/tkpIEJvhrBiIow - видео с проблемой

Воспроизведение проблемы

Пример: https://doc.prizm.zyfra.com/components/scrollbar

Описание проблемы

У одной из наших сотрудниц в браузере не показывается полоса прокрутки, если задать в классе visibility=visible тогда показывается а если просто style остается то у нее ничего не показывает. Настройки хрома пробовали крутить вертеть не помогло.

В общем рекомендую явно прописать для элемента prizm-scroll-controls - стиль visibility:visible
@stepandr
Copy link
Contributor Author

stepandr commented Oct 4, 2023

Проблема так же связана с #491 - но тут похоже что она не решилась

@alexhawkins94 alexhawkins94 added the type:bug Something isn't working label Oct 4, 2023
@ZurabDev
Copy link
Contributor

ZurabDev commented Oct 6, 2023

Для контроля есть опция
CleanShot 2023-10-06 at 15 33 22@2x

@alexhawkins94
Copy link

@stepandr актуально? ответ выше помог?

@AntonGrekov
Copy link

@alexhawkins94
@ZurabDev

ответ выше не удаётся применить, т.к. у нас окно со скролом вызывается через PrizmConfirmDialogService, а у него в опциях данной настройки нет. Нашёл только overscrollMode, наверно это другое, да ?

@AntonGrekov
Copy link

@ZurabDev @alexhawkins94 как быть в ситуации описанной выше ?

@ZurabDev ZurabDev added this to the 3.6.0 milestone Nov 20, 2023
@ZurabDev ZurabDev self-assigned this Nov 20, 2023
@ZurabDev ZurabDev added extra Not planed initially for sprint source:requested The tag indicates that the information or action being discussed was initiate labels Nov 20, 2023
@ZurabDev ZurabDev modified the milestones: 3.6.0, 3.8.0, 3.8.0_ Nov 28, 2023
@ZurabDev ZurabDev modified the milestones: 3.8.0, 3.9.0 Dec 7, 2023
@AntonGrekov
Copy link

Коллеги, подскажите статус по этой задаче ? @ZurabDev @alexhawkins94

@alexhawkins94
Copy link

@AntonGrekov пока планируем в 3.9

@ZurabDev может что-то еще посоветуешь?

@ZurabDev
Copy link
Contributor

Привет.
Да след неделю завершить постараемся @AntonGrekov @alexhawkins94

@ZurabDev ZurabDev added the priority:urgently "Tag: priority:urgently — Marks tasks or issues that require immediate attention and action. These a label Dec 13, 2023
ZurabDev added a commit that referenced this issue Dec 25, 2023
@ZurabDev
feat(components/dialog): added ability to control scrollbar visibility …
3e74c7e 
…#780
@ZurabDev ZurabDev mentioned this issue Dec 25, 2023
Merged
ZurabDev added a commit that referenced this issue Dec 29, 2023
@ZurabDev
Merge pull request #1233 from zyfra/feat/dialog-scrolbarr-control
3a3f375 
feat(components/sidebar): added ability to control scrollbar visibility #780
@ZurabDev ZurabDev mentioned this issue Dec 29, 2023
Merged
@ickisIckis ickisIckis mentioned this issue Jul 26, 2024
Open
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ZurabDev ZurabDev

Labels
extra Not planed initially for sprint need_more_information priority:urgently "Tag: priority:urgently — Marks tasks or issues that require immediate attention and action. These a source:requested The tag indicates that the information or action being discussed was initiate type:bug Something isn't working
Projects
Roadmap Prizm
Archived in project
Milestone
3.9.0
Development

Successfully merging a pull request may close this issue.

feat(components/sidebar): added ability to control scrollbar visibility #780 zyfra/Prizm
4 participants
@stepandr @AntonGrekov @ZurabDev @alexhawkins94