Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(components/calendar): scroll in to view in year/month pickers #760 #1198

Merged
merged 8 commits into from
Dec 20, 2023
Merged

fix(components/calendar): scroll in to view in year/month pickers #760 #1198

merged 8 commits into from
Dec 20, 2023

Conversation

ZurabDev
Copy link
Contributor

@ZurabDev ZurabDev commented Dec 15, 2023 •
edited
Loading

Resolved #760

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 15, 2023 •
edited
Loading

Visit the preview URL for this PR (updated for commit 4b3935e):

https://prizm-v3--pr1198-fix-dev-mode-ci-1coicnpi.web.app

(expires Sat, 23 Dec 2023 11:25:37 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 6cf3db9b3e1bf46180849c1db2e28221d0904ddf

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 15, 2023 •
edited
Loading

Visit the preview URL for this PR (updated for commit 4b3935e):

https://prizm-v1--pr1198-fix-dev-mode-ci-7y6tr6jc.web.app

(expires Sat, 23 Dec 2023 11:27:55 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 3f40bac4652dbd13be483e7e4de02de469ed4b3f

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 15, 2023 •
edited
Loading

Visit the preview URL for this PR (updated for commit 4b3935e):

https://prizm-v2--pr1198-fix-dev-mode-ci-h536a4tn.web.app

(expires Sat, 23 Dec 2023 11:28:18 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: ab7e21e23e82e687a92ac5a830ac2768df6e61b5

@ZurabDev ZurabDev changed the title fix: ci dev configuration for beta fix(components/calendar): scroll in to view in year/month pickers #760 Dec 18, 2023
ickisIckis
ickisIckis approved these changes Dec 18, 2023
View reviewed changes
Copy link
Collaborator

@ickisIckis ickisIckis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

libs/components/src/lib/directives/pressed/pressed.directive.ts
Comment on lines +5 to +7
/**
*
* */
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/**
*
* */

@alexhawkins94 alexhawkins94 added state:ready ready for release (pass tested) availability:tested and removed availability:reviewed Ready to test labels Dec 19, 2023
@ZurabDev ZurabDev added this to the 3.8.0 milestone Dec 20, 2023
@ZurabDev ZurabDev merged commit 528ed0d into main Dec 20, 2023
12 checks passed
@ZurabDev ZurabDev mentioned this pull request Dec 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ickisIckis ickisIckis ickisIckis approved these changes

@alexhawkins94 alexhawkins94 alexhawkins94 approved these changes

Assignees
No one assigned
Labels
availability:tested state:ready ready for release (pass tested)
Projects
None yet
Milestone
3.8.0
3 participants
@ZurabDev @ickisIckis @alexhawkins94