Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(components/input-layout-date-time): after clear set state #1076 #1208

Merged
merged 1 commit into from
Dec 20, 2023

Conversation

ZurabDev
Copy link
Contributor

fix(components/input-layout-date-time): after clear set state #1076

Resolved #1076

Copy link

Visit the preview URL for this PR (updated for commit e4867ee):

https://prizm-v3--pr1208-fix-components-input-pzj2fjn7.web.app

(expires Sat, 23 Dec 2023 07:06:56 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 6cf3db9b3e1bf46180849c1db2e28221d0904ddf

Copy link

Visit the preview URL for this PR (updated for commit e4867ee):

https://prizm-v2--pr1208-fix-components-input-ibzoshfc.web.app

(expires Sat, 23 Dec 2023 07:08:48 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: ab7e21e23e82e687a92ac5a830ac2768df6e61b5

Copy link

Visit the preview URL for this PR (updated for commit e4867ee):

https://prizm-v1--pr1208-fix-components-input-rb3zmga3.web.app

(expires Sat, 23 Dec 2023 07:09:06 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 3f40bac4652dbd13be483e7e4de02de469ed4b3f

@@ -495,8 +494,9 @@ export class PrizmInputLayoutDateTimeComponent
ev.stopImmediatePropagation();
super.clear(ev);
this.nativeValue$$.next(['', '']);
this.updateValue([null, null]);
this.layoutComponent.cdr.markForCheck();
this.updateValue(null);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Мне кажется, в этом месте теоретически может быть breaking. Тк раньше после очистки значение было массивом

@ickisIckis ickisIckis self-requested a review December 18, 2023 08:25
Copy link
Collaborator

@ickisIckis ickisIckis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexhawkins94 alexhawkins94 added state:ready ready for release (pass tested) availability:tested and removed availability:reviewed Ready to test labels Dec 18, 2023
@ZurabDev ZurabDev merged commit 6b03db1 into main Dec 20, 2023
9 checks passed
@ZurabDev ZurabDev mentioned this pull request Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
availability:tested state:ready ready for release (pass tested)
Projects
None yet
3 participants