Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(components/chips): dots overflows chip list container #1713 v3 #1739

Merged
merged 2 commits into from
May 31, 2024

Conversation

ickisIckis
Copy link
Collaborator

@ickisIckis ickisIckis commented May 28, 2024

fix(components/chips): dots overflows chip list container #1713
refactor(components/chips): move multiply subscriptions to prizmLet

Исправлена ошибка в верстке при переполнении контейнера с чипсами в InputMultiSelect и InputChips singleLine.
Улучшили производительность компонента Chips с помощью оптимизации подписок в шаблоне.

Обратить внимание при тестировании
InputMultiSelect и InputChips, особенно состояние singleLine. Стоит проверить отступы справа внутри указанных компонентов.
Сценарий воспроизведения проблемы: выбрано больше одного чипса, ширина первого из выбранных чипсов превышает ширину контейнера. Соответствующий пример добавлен в InputMultiSelect, для InputChips доступен для воспроизведения в LiveDemo.

resolved #1713

@ickisIckis ickisIckis added this to the 3.13.2 milestone May 28, 2024
@ickisIckis ickisIckis requested a review from ZurabDev May 28, 2024 11:46
Copy link
Contributor

@ZurabDev ZurabDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ickisIckis ickisIckis changed the title fix(components/chips): dots overflows chip list container #1713 fix(components/chips): dots overflows chip list container #1713 v3 May 29, 2024
@ickisIckis ickisIckis added state:ready ready for release (pass tested) version:3 labels May 30, 2024
@ickisIckis ickisIckis merged commit 3485d01 into v3 May 31, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
availability:tested state:ready ready for release (pass tested) version:3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants