Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(components/paginator): fixed PrizmPaginatorComponent instance was incompatible with PrizmDataSource.paginator #1745

Conversation

AleksandrSibiakov
Copy link
Contributor

@AleksandrSibiakov AleksandrSibiakov commented May 29, 2024

fix(components/paginator): fixed PrizmPaginatorComponent instance was incompatible with PrizmTableDataSource.paginator property

resolved #1746

Also, for the PrizmTableDataSource, some properties in related interfaces were marked as read-only because they are not intended to be changed.

… incompatible with PrizmDataSource.paginator
Copy link

Visit the preview URL for this PR (updated for commit df8022e):

https://prizm-v4--pr1745-fix-datasource-incom-9zrb475h.web.app

(expires Mon, 03 Jun 2024 15:18:15 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 7c62ed8dbabf5e2d6b2084ca9e107cc206d30dbd

Copy link
Contributor

@ZurabDev ZurabDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZurabDev ZurabDev added this to the 4.3.1 milestone May 31, 2024
@ZurabDev ZurabDev merged commit 94a6093 into zyfra:main May 31, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants