Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/datasource incompatible with paginator v3 #1752

Merged
merged 1 commit into from
May 31, 2024

Conversation

ickisIckis
Copy link
Collaborator

fix(components/paginator): fixed PrizmPaginatorComponent instance was incompatible with PrizmTableDataSource.paginator property

resolved #1746

Also, for the PrizmTableDataSource, some properties in related interfaces were marked as read-only because they are not intended to be changed.

Исправлена типизация PrizmTableDataSource

@ickisIckis ickisIckis added this to the 3.13.2 milestone May 31, 2024
@ickisIckis ickisIckis requested a review from ZurabDev May 31, 2024 08:52
@ickisIckis ickisIckis changed the base branch from main to v3 May 31, 2024 08:52
Copy link
Contributor

@ZurabDev ZurabDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ickisIckis ickisIckis added state:ready ready for release (pass tested) labels May 31, 2024
@ickisIckis ickisIckis merged commit 99e6808 into v3 May 31, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
availability:reviewed Ready to test devOnly state:ready ready for release (pass tested) version:3
Projects
None yet
3 participants