fix(components/switcher): fix async support for selected switcher #1476 #1839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 318395f): https://prizm-v4--pr1839-fix-switcher-input-o-l026me23.web.app (expires Mon, 15 Jul 2024 10:48:38 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 7c62ed8dbabf5e2d6b2084ca9e107cc206d30dbd |
ickisIckis
force-pushed
the
fix/switcher-input-order-1476
branch
from
39cac6c
to
8f1f3d8
Compare
ickisIckis
added
availability:review
and removed
state:in_progress
ickisIckis
changed the title
ZurabDev
reviewed
Jul 5, 2024
libs/components/src/lib/components/switcher/switcher.component.ts
Outdated
Show resolved
Hide resolved
ZurabDev
added
availability:reviewed
|
Ошибка в консоли при переходе в примеры свитчера |
ZurabDev
reviewed
Jul 9, 2024
| takeUntil(this.destroy$) | ||
| ) | ||
| .subscribe(([switchers, selectedSwitcherIdx]) => { | ||
| if (!switchers.length) return; |
There was a problem hiding this comment.
Может вот эту логику перенести в tap до takeUntil
Сомтреть код в tap бывает удобно, а то у нас тут получилось что есть один тап потом часть в subscribe
https://blog.angulartraining.com/three-reasons-to-use-the-tap-operator-from-rxjs-6828fcf288ec
There was a problem hiding this comment.
Хороший поинт, спасибо!
ickisIckis
force-pushed
the
fix/switcher-input-order-1476
branch
from
06b1554
to
cc08d66
Compare
ZurabDev
added
availability:reviewed
ickisIckis
force-pushed
the
fix/switcher-input-order-1476
branch
from
cc08d66
to
6b41df0
Compare
alexhawkins94
added
availability:tested
and removed
availability:reviewed
alexhawkins94
approved these changes
Jul 10, 2024
ZurabDev
added a commit
that referenced
this pull request
Sep 20, 2024
fix(components/switcher): fix async support for selected switcher #1476
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(components/switcher): add async example for issue #1476
Библиотека
@prizm-ui/components@prizm-ui/install@prizm-ui/icons@prizm-ui/themeКомпонент
Switcher
Задача
resolved #1476
Изменения
Checklist:
Следует обратить внимание на ревью
Установка и смена выбранного элемента в свитчере и компонентах, его содержащих (крон etc)