feat(components/paginator): add left direction support #1154 #1886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit fa13510): https://prizm-v4--pr1886-feat-paginator-left-38vqhrwj.web.app (expires Mon, 12 Aug 2024 10:21:06 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 7c62ed8dbabf5e2d6b2084ca9e107cc206d30dbd |
ZurabDev
reviewed
Jul 29, 2024
| @Input() | ||
| @HostBinding('class.direction-left') | ||
| @prizmDefaultProp() | ||
| public directionLeft = false; |
There was a problem hiding this comment.
Может добавить direction c по умалчанием значением right
There was a problem hiding this comment.
Да. отлично. Так и сделаем.
added 2 commits
July 29, 2024 11:36
ZurabDev
added
availability:reviewed
|
Для левой раскладки не хватает margin left для "Показано строк". |
alexhawkins94
approved these changes
Aug 8, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Библиотека
@prizm-ui/components@prizm-ui/install@prizm-ui/icons@prizm-ui/themeКомпонент
Paginator
Задача
resolved #1154
Изменения
Checklist:
Следует обратить внимание на ревью
Реализация через boolean, возможно стоит сделать через left | right, где right - дефолтное?
Следует обратить внимание при тестировании
Верстка пагинатора с левым и правым расположением
Release Notes
Реализовали вариант расположения элементов управления в пагинаторе - слева направо.