fix(components/file-upload): emit events for clear files fix #1848 #1939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit b78d8be): https://prizm-v4--pr1939-fix-file-upload-clea-t613po62.web.app (expires Mon, 12 Aug 2024 11:52:21 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 7c62ed8dbabf5e2d6b2084ca9e107cc206d30dbd |
alexhawkins94
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(components/file-upload): emit events for clear files fix #1848
Библиотека
@prizm-ui/components@prizm-ui/install@prizm-ui/icons@prizm-ui/themeКомпонент
FileUpload
Задача
resolved #1858
Изменения
Checklist:
Следует обратить внимание при тестировании
Способ проверки: multiply = false, добавить один файл, затем заменить его другим. Cобытия beforeFilesChange и аilesChange должно сработать 1 раз, на проде сейчас дублируются из-за ошибки в логике.
Release Notes
Исправили ошибку в поведении функции ClearFiles c опцией emitEvent: false