Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(components/tabs): correct focus styles for contained tabs #1729 #2056

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ickisIckis
Copy link
Collaborator

fix(components/tabs): correct focus styles for contained tabs #1729

Библиотека

  • @prizm-ui/components
  • @prizm-ui/install
  • @prizm-ui/icons
  • @prizm-ui/theme

Компонент

Tabs

Задача

resolved #1729

Изменения

  • Имеются BREAKING CHANGES
  • Изменения документации
  • Добавление фичи
  • Исправление бага

Checklist:

  • После фичи обновил документацию
  • Сделал код чище чем был до этого
  • Тесты и линтер на рабочей машине успешно выполнились

Release Notes

Исправили верстку contined табов, находящихся в фокусе.

Copy link

github-actions bot commented Sep 11, 2024

Visit the preview URL for this PR (updated for commit 47e8ca6):

https://prizm-v4--pr2056-fix-tab-contained-fo-1gyxntpg.web.app

(expires Sun, 20 Oct 2024 12:18:51 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 7c62ed8dbabf5e2d6b2084ca9e107cc206d30dbd

Copy link
Contributor

@ZurabDev ZurabDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexhawkins94
Copy link

При перемещении фокуса происходит сдвиг текста внутри - contained tabs
chrome_g0CuOHZZqx

@ickisIckis
Copy link
Collaborator Author

По согласованию с @PrizmDS увеличили ширину border right для contained tabs до 2px
макеты будут обновлены

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Int] Contained tabs. Рамка фокуса на табе сдвигает соседний таб
3 participants