Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(components/breadcrumbs): Added option to show only icon in breadcrumb, removing 8px gap and empty text padding. #222

Merged
merged 3 commits into from
Apr 28, 2023
Merged

fix(components/breadcrumbs): Added option to show only icon in breadcrumb, removing 8px gap and empty text padding. #222

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0f753d4
fix(components/breadcrumbs): make BreadcrumbsComponent generic
digital-plant-guard Apr 27, 2023
d0c8dfb
fix(components/breadcrumbs): fix icon-only breadcrumbs gap
digital-plant-guard Apr 27, 2023
748c107
fix(docs/breadcrumbs): add icon-only breadcrumb example
digital-plant-guard Apr 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ...dcrumbs/examples/breadcrumbs-example-with-icon/breadcrumbs-example-with-icon.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,10 @@ import { IBreadcrumb } from '@prizm-ui/components';
})
export class BreadcrumbsExampleWithIconComponent {
public breadcrumbs: IBreadcrumb[] = [
{
name: '',
icon: 'social-home-breadcrumbs',
},
{
name: 'Lady',
icon: 'account',
Expand Down
4 changes: 2 additions & 2 deletions libs/components/src/lib/components/breadcrumbs/breadcrumbs.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,9 @@
class="breadcrumb__icon"
[size]="16"
[iconClass]="breadcrumb.icon"
*ngIf="!!breadcrumb.icon"
*ngIf="breadcrumb.icon"
></prizm-icon>
<span class="breadcrumb__name">{{ breadcrumb?.name }}</span>
<span *ngIf="breadcrumb.name" class="breadcrumb__name">{{ breadcrumb.name }}</span>
</button>

<prizm-dropdown-host
Expand Down
18 changes: 10 additions & 8 deletions libs/components/src/lib/components/breadcrumbs/breadcrumbs.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,26 +26,28 @@ import { debounceTime, observeOn, takeUntil, tap } from 'rxjs/operators';
changeDetection: ChangeDetectionStrategy.OnPush,
providers: [PrizmDestroyService],
})
export class BreadcrumbsComponent implements OnInit, OnDestroy, AfterViewInit {
@Input() set breadcrumbs(data: IBreadcrumb[]) {
export class BreadcrumbsComponent<Breadcrumb extends IBreadcrumb>
implements OnInit, OnDestroy, AfterViewInit
{
@Input() set breadcrumbs(data: Breadcrumb[]) {
this.breadcrumbs$.next(data);
}

public get breadcrumbs(): IBreadcrumb[] {
public get breadcrumbs(): Breadcrumb[] {
return this.breadcrumbs$.getValue();
}

@HostBinding('attr.testId')
readonly testId = 'prizm_breadcrumbs';

@Output() public breadcrumbChange: EventEmitter<IBreadcrumb> = new EventEmitter();
@Output() public breadcrumbChange: EventEmitter<Breadcrumb> = new EventEmitter();
@ViewChild('container', { static: true }) public containerRef: ElementRef;
@ViewChild('breadcrumbsFake', { static: true }) public fakeBreadcrumbContainer: ElementRef;
@ViewChildren('breadcrumb', { read: ElementRef }) public breadcrumbsList: QueryList<ElementRef>;

public breadcrumbs$: BehaviorSubject<IBreadcrumb[]> = new BehaviorSubject<IBreadcrumb[]>([]);
public breadcrumbsToShow$: BehaviorSubject<IBreadcrumb[]> = new BehaviorSubject<IBreadcrumb[]>([]);
public breadcrumbsInMenu$: BehaviorSubject<IBreadcrumb[]> = new BehaviorSubject<IBreadcrumb[]>([]);
public breadcrumbs$: BehaviorSubject<Breadcrumb[]> = new BehaviorSubject<Breadcrumb[]>([]);
public breadcrumbsToShow$: BehaviorSubject<Breadcrumb[]> = new BehaviorSubject<Breadcrumb[]>([]);
public breadcrumbsInMenu$: BehaviorSubject<Breadcrumb[]> = new BehaviorSubject<Breadcrumb[]>([]);

public isDropdownOpened = false;
public isContainerOverflowed = false;
Expand Down Expand Up @@ -116,7 +118,7 @@ export class BreadcrumbsComponent implements OnInit, OnDestroy, AfterViewInit {
this.breadcrumbsElementsWidth = this.fakeBreadcrumbContainer.nativeElement.clientWidth;
}

private setViewBreadcrumbs(breadcrumbs: IBreadcrumb[]): void {
private setViewBreadcrumbs(breadcrumbs: Breadcrumb[]): void {
if (this.isContainerOverflowed) {
this.breadcrumbsInMenu$.next(breadcrumbs.filter((item, i) => i > 0 && i < breadcrumbs.length - 1));
this.breadcrumbsToShow$.next(breadcrumbs.filter((item, i) => i === 0 || i === breadcrumbs.length - 1));
Expand Down