Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(components/input): empty label mode for iner #384 #920

Merged
merged 2 commits into from
Nov 1, 2023

Conversation

ZurabDev
Copy link
Contributor

@ZurabDev ZurabDev commented Oct 30, 2023

feat(components/input): empty label mode for inner #384

!!! Check all input on empty mode and non label mode

Resolved #384

@ZurabDev ZurabDev added the state:ready ready for release (pass tested) label Oct 30, 2023
@ZurabDev ZurabDev added this to the 3.4.0 milestone Oct 30, 2023
@ZurabDev ZurabDev self-assigned this Oct 30, 2023
@github-actions
Copy link

Visit the preview URL for this PR (updated for commit 40cea0f):

https://prizm-v1--pr920-feat-input-empty-lab-teg65ljx.web.app

(expires Sat, 04 Nov 2023 08:43:30 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 3f40bac4652dbd13be483e7e4de02de469ed4b3f

@github-actions
Copy link

Visit the preview URL for this PR (updated for commit 40cea0f):

https://prizm-v2--pr920-feat-input-empty-lab-xicsr4y1.web.app

(expires Sat, 04 Nov 2023 08:44:13 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: ab7e21e23e82e687a92ac5a830ac2768df6e61b5

@github-actions
Copy link

Visit the preview URL for this PR (updated for commit 40cea0f):

https://prizm-v3--pr920-feat-input-empty-lab-56d28a7e.web.app

(expires Sat, 04 Nov 2023 08:44:39 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 6cf3db9b3e1bf46180849c1db2e28221d0904ddf

Copy link

@alexhawkins94 alexhawkins94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

label = null, placeholder = some_text, outer = false

Input Multiselect, Input Select - placeholder не отображается
2023-10-30_12-16-42

InputDateTIme, DateTimeRange, DateRange - placeholder "прижат" к нижнему краю инпута
2023-10-30_12-16-58

InputText, Password, Number, Carousel, Chips не могу проверить т.к. отсутствуют нужные атрибуты

@ZurabDev ZurabDev merged commit 84e6fa2 into main Nov 1, 2023
2 of 5 checks passed
@ZurabDev ZurabDev mentioned this pull request Nov 1, 2023
@ZurabDev
Copy link
Contributor Author

ZurabDev commented Nov 1, 2023

CleanShot 2023-11-01 at 17 35 36

label = null, placeholder = some_text, outer = false

Input Multiselect, Input Select - placeholder не отображается 2023-10-30_12-16-42

InputDateTIme, DateTimeRange, DateRange - placeholder "прижат" к нижнему краю инпута 2023-10-30_12-16-58

InputText, Password, Number, Carousel, Chips не могу проверить т.к. отсутствуют нужные атрибуты

Верно у них нет placeholder

@ZurabDev
Copy link
Contributor Author

ZurabDev commented Nov 1, 2023

label = null, placeholder = some_text, outer = false

Input Multiselect, Input Select - placeholder не отображается 2023-10-30_12-16-42

InputDateTIme, DateTimeRange, DateRange - placeholder "прижат" к нижнему краю инпута 2023-10-30_12-16-58

InputText, Password, Number, Carousel, Chips не могу проверить т.к. отсутствуют нужные атрибуты

CleanShot 2023-11-01 at 17 35 36

Готово

@ZurabDev ZurabDev mentioned this pull request Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:ready ready for release (pass tested) state:reopen
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] - Отображать плейсхолдер в inner input при label=null
2 participants