Ingestion Speedup Multiple strategy #1309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Multiprocessing map is used to perform CPU bound operations on the file that have to be ingested. TODO: make the ingestion script to use the bulk method
This way, we do not have to use `global` keyword
Also made the argument parsing and the initialization of dependency context as late as possible, in order to fail fast and return the help faster.
The profile `ingest-local` does not load the LLM, but it does load the embedding model.
…he API Create a shell (IngestionHelper) to hold the file to documents conversion, as well as the metadata modification. Also, made the code simpler by simplifying the typing and the potential hack to perform if the `file_data` given the actual data, instead of a path to the file.
…nent Exposing different ways of parallelization of file ingestion.
imartinez
requested changes
Nov 25, 2023
imartinez
approved these changes
Nov 25, 2023
|
Follow up PR that fixes the parallel ingestion: #1336 |
simonbermudez
pushed a commit
to simonbermudez/saimon
that referenced
this pull request
Feb 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiple strategy for file ingestion.
This is good to be pushed as is.
Following PR will come to add a switch between the implementation using the configuration.
Documentation should be added as well.
Ideally, the most optimal implementation should be debugged as well in this future PR.
The current behavior is preserved and will not impact the existing users