Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to .NET 9 SDK #2003

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from
Draft

Update to .NET 9 SDK #2003

wants to merge 12 commits into from

Conversation

martincostello
Copy link
Member

@martincostello martincostello commented Mar 1, 2024

A long-lived PR for testing .NET 9 until the stable release in November 2024. net9.0 is explicitly not being added as a new TFM for the packages we ship to NuGet.org.

Changes include:

  • Update to the .NET 9 SDK.
  • Add usage of [DebuggerDisableUserUnhandledExceptions] to avoid newer versions of the Visual Studio debugger for breaking for exceptions on async code paths we are intentionally handling.
  • Target net8.0 and net9.0 in tests, samples and benchmarks.
  • Remove net6.0 target from tests, samples and benchmarks as it will both be out-of-support by November 2024.
  • Fix/suppress new IDE0022/S3236 warnings.
  • Only enable NuGet Audit for direct dependencies, not transient ones.

@martincostello martincostello added dependencies Pull requests that update a dependency file .NET Pull requests that update .NET code labels Mar 1, 2024
martincostello added a commit to martincostello/Polly that referenced this pull request Mar 1, 2024
- Fix CA1849 warning from updating snippets to .NET 8.
- Fix IDE0034 warning identified by the .NET 9 SDK in App-vNext#2003.
martincostello added a commit that referenced this pull request Mar 1, 2024
- Update various sample projects from `net7.0` to `net8.0`.
- Fix CA1849 warning from updating snippets to .NET 8.
- Fix IDE0034 warning identified by the .NET 9 SDK in #2003.
Copy link

codecov bot commented Mar 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.36%. Comparing base (14ac109) to head (73c7feb).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2003      +/-   ##
==========================================
- Coverage   85.40%   85.36%   -0.04%     
==========================================
  Files         313      312       -1     
  Lines        7467     7449      -18     
  Branches     1125     1121       -4     
==========================================
- Hits         6377     6359      -18     
  Misses        745      745              
  Partials      345      345              
Flag Coverage Δ
linux 85.34% <100.00%> (-0.07%) ⬇️
macos 85.34% <100.00%> (-0.07%) ⬇️
windows 85.34% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

martincostello added a commit to martincostello/Polly that referenced this pull request Apr 12, 2024
Fix IDE0057 warnings identified in App-vNext#2003.
martincostello added a commit that referenced this pull request Apr 12, 2024
Fix IDE0057 warnings identified in #2003.
@martincostello martincostello force-pushed the dotnet-vnext branch 2 times, most recently from bee5858 to eeac2c2 Compare May 15, 2024 11:22
@martincostello martincostello force-pushed the dotnet-vnext branch 2 times, most recently from f18d2e9 to ff96865 Compare May 29, 2024 10:42
@martincostello martincostello force-pushed the dotnet-vnext branch 2 times, most recently from 28ff68a to 9aa38cf Compare October 11, 2024 07:55
martincostello and others added 11 commits October 16, 2024 10:43
- Build with the .NET 9 (preview 6) SDK.
- Add tests TFM for `net9.0`.
- Remove tests for `net6.0` TFM.
- Run workflows on PRs to `dotnet-vnext` branch.
- Only audit direct NuGet dependencies.
- Fix IDE0022 warning.
- Temporarily disable some tests that are failing in GitHub Actions.
Disable TFM parallelism for `dotnet test` in the Polly.Core project on Windows to fix two failing tests.
See https://learn.microsoft.com/dotnet/core/whats-new/dotnet-9/sdk#run-tests-in-parallel.
Set the coverage threshold back to 100%.
Update .NET SDK to version 9.0.100-preview.7.24407.12.

---
updated-dependencies:
- dependency-name: Microsoft.NET.Sdk
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: polly-updater-bot[bot] <138034000+polly-updater-bot[bot]@users.noreply.github.com>
Co-authored-by: polly-updater-bot[bot] <138034000+polly-updater-bot[bot]@users.noreply.github.com>
Update NuGet packages for .NET 9 preview 7.
Update Microsoft.Extensions.TimeProvider.Testing to .NET 9 preview 7.
Update .NET SDK to version 9.0.100-rc.1.24452.12.

---
updated-dependencies:
- dependency-name: Microsoft.NET.Sdk
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: polly-updater-bot[bot] <138034000+polly-updater-bot[bot]@users.noreply.github.com>
Co-authored-by: polly-updater-bot[bot] <138034000+polly-updater-bot[bot]@users.noreply.github.com>
Update NuGet packages for RC1.
Update the TimeProvider testing package to preview 8.
Update .NET SDK to version 9.0.100-rc.2.24474.11.

---
updated-dependencies:
- dependency-name: Microsoft.NET.Sdk
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: polly-updater-bot[bot] <138034000+polly-updater-bot[bot]@users.noreply.github.com>
Co-authored-by: polly-updater-bot[bot] <138034000+polly-updater-bot[bot]@users.noreply.github.com>
Bump NuGet packages for .NET 9 RC 2.
- Add usage of `[DebuggerDisableUserUnhandledExceptions]` to avoid newer versions of the Visual Studio debugger for breaking for exceptions on async code paths we are intentionally handling.
- Add copy of `[DebuggerDisableUserUnhandledExceptions]` for use in downlevel versions of .NET that do not contain the attribute.
@martincostello martincostello added this to the v8.5.0 milestone Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file .NET Pull requests that update .NET code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant