This repository has been archived by the owner on Feb 6, 2022. It is now read-only.
Add explicit line-height to .libjass-font-measure #46
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently line-height for .libjass-font-measure determined by site css. For example if you run libjass on github.com then line-height for .libjass-font-measure would be 1.4. Of course that's not correct that line-height and font size in subtitles determined by site css.
I'm put "1.15" and not "normal" because:
"1.15" looks similar to line-height used in libass/VSFilter. Maybe you know where in libass sources I can find real value of line-height?
BTW, if line-height is constant then maybe libjass-font-mesure is unnecessary? I mean if we know line-height then we can compute line-height and font-size without putting symbol in .libjass-font-measure.