Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove GutenbergBlockManipulator, transformer and transformer command #548

Open
wants to merge 4 commits into
base: trunk
Choose a base branch
from

Conversation

naxoc
Copy link
Member

@naxoc naxoc commented Oct 14, 2024

@naxoc naxoc self-assigned this Oct 14, 2024
@naxoc naxoc requested a review from eddiesshop October 15, 2024 15:34
Copy link
Collaborator

@eddiesshop eddiesshop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the question on the phpcs.yml, is PostSelect a new class only in NMT? Meaning there was no equivalent in NCCM to remove?

@@ -17,7 +17,7 @@ jobs:
- name: Check for PHP file changes
id: check_php_changes
run: |
CHANGED_PHP_FILES=$(git diff --name-only ${{ github.event.pull_request.base.sha }}...${{ github.event.pull_request.head.sha }} | grep '\.php$' || echo 'no files')
CHANGED_PHP_FILES=$(git diff --diff-filter=d --name-only ${{ github.event.pull_request.base.sha }}...${{ github.event.pull_request.head.sha }} | grep '\.php$' || echo 'no files')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this intentional? Filter for only deleted files?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants