Move GutenbergBlockManipulator, transformer and transformer command #28
+772
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* WIP * Works in theory * Add a block-en/decoder for use with NCC * Code style stuff * Add min and max for post processing * Refactor a bit into two classes * Repeat myself in comments
* Add NCC trickery * Also allow NCC nudge in encode * Better logging and querying * Make things work with all flags and args * Some code style * Order when processsing to avoid programmer confusion * Remove NCC batch resetter - it's gone in the NCC too * Added checks in case the post update fail
* WIP * Works in theory * Add a block-en/decoder for use with NCC * Code style stuff * Add min and max for post processing * Refactor a bit into two classes * Repeat myself in comments
* Add NCC trickery * Also allow NCC nudge in encode * Better logging and querying * Make things work with all flags and args * Some code style * Order when processsing to avoid programmer confusion * Remove NCC batch resetter - it's gone in the NCC too * Added checks in case the post update fail
* Use a closure to delay instantiation * Leave $this alone * Refactor the rest of the command classes * Added comment * Update newspack-migration-tools
naxoc
commented
Oct 15, 2024
| @@ -4,7 +4,7 @@ on: [ pull_request ] | |||
|
|
|||
| jobs: | |||
| unit-tests: | |||
| runs-on: ubuntu-latest | |||
| runs-on: ubuntu-22.04 | |||
There was a problem hiding this comment.
See apache/beam#32766 – this is temporary. I'll switch it back when it's fixed.
eddiesshop
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move over and minimally refactor to use the new classes. History is move over too using the below. The
git format-patchis fired in the NCMM and thegit amcommand is fired in the NMT.