Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query: Fixes bug in OrderByCrossPartitionQueryPipelineStage to ensure that errors in inner pipeline creation are bubbled up #4419

Merged

Conversation

neildsh
Copy link
Contributor

@neildsh neildsh commented Apr 15, 2024

Description

Fixes bug in OrderByCrossPartitionQueryPipelineStage to ensure that errors in inner pipeline creation are bubbled up to the higher stages

Type of change

  • Bug fix (non-breaking change which fixes an issue)

…lures in creating the inner pipeline stage are bubbled up to the higher stages
Copy link
Contributor

@adityasa adityasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@neildsh
Copy link
Contributor Author

neildsh commented Apr 16, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@neildsh
Copy link
Contributor Author

neildsh commented Apr 16, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@neildsh
Copy link
Contributor Author

neildsh commented Apr 16, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@neildsh
Copy link
Contributor Author

neildsh commented Apr 16, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@neildsh neildsh added QUERY auto-merge Enables automation to merge PRs labels Apr 16, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot merged commit 08338af into master Apr 16, 2024
21 checks passed
@microsoft-github-policy-service microsoft-github-policy-service bot deleted the users/ndeshpan/orderByErrorReporting branch April 16, 2024 19:24
adityasa pushed a commit that referenced this pull request May 16, 2024
…lures in creating the inner pipeline stage are bubbled up to the higher stages (#4419)
microsoft-github-policy-service bot pushed a commit that referenced this pull request May 16, 2024
…ch (#4498)

* Fix bug in OrderByCrossPartitionQueryPipelineStage to ensure that failures in creating the inner pipeline stage are bubbled up to the higher stages (#4419)

* Query: Fixes Persisted continuationToken issue by turning off ODE by default (#4413)

* Turn of ODE by default.

* Updated tests

* Update

* Test fix

* Added test for query resumption with ODE token with partition split container (failure case).

* Update.

* Update Benchmark

* Addressed comments.

---------

Co-authored-by: neildsh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge Enables automation to merge PRs QUERY
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants