Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query : Fixes ODE and ORDER BY issue by cherry picking to hotfix branch #4498

Merged
merged 2 commits into from
May 16, 2024
Merged

Query : Fixes ODE and ORDER BY issue by cherry picking to hotfix branch #4498

merged 2 commits into from
May 16, 2024

Conversation

adityasa
Copy link
Contributor

@adityasa adityasa commented May 16, 2024 •
edited
Loading

Pull Request Template

Description

This change cherry-picks following two commits to the hotfix branch releases/3.39.2_redo:

git cherry-pick 08338af63
Fix bug in OrderByCrossPartitionQueryPipelineStage to ensure that failures in creating the inner pipeline stage are bubbled up to the higher stages (#4419)

git cherry-pick 14633455d
Query: Fixes Persisted continuationToken issue by turning off ODE by default (#4413)

Please note the previous hotfix branch releases/3.39.2 is abandoned.
 

Type of change

Please delete options that are not relevant.

  • [] Bug fix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [] This change requires a documentation update

Closing issues

To automatically close an issue: closes #IssueNumber

neildsh and others added 2 commits May 15, 2024 18:06
@neildsh @adityasa
Fix bug in OrderByCrossPartitionQueryPipelineStage to ensure that fai…
9c849a1 
…lures in creating the inner pipeline stage are bubbled up to the higher stages (#4419)
@adityasa
Query: Fixes Persisted continuationToken issue by turning off ODE by …
1079832 
…default (#4413)

* Turn of ODE by default.

* Updated tests

* Update

* Test fix

* Added test for query resumption with ODE token with partition split container (failure case).

* Update.

* Update Benchmark

* Addressed comments.
@adityasa adityasa added the auto-merge Enables automation to merge PRs label May 16, 2024
@adityasa adityasa marked this pull request as ready for review May 16, 2024 02:32
@neildsh neildsh added the QUERY label May 16, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot merged commit db45a83 into releases/3.39.2_redo May 16, 2024
23 checks passed
@microsoft-github-policy-service microsoft-github-policy-service bot deleted the users/adityasa/CherryPickODERevert_redo branch May 16, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kirankumarkolli kirankumarkolli kirankumarkolli approved these changes

@neildsh neildsh neildsh approved these changes

@khdang khdang Awaiting requested review from khdang

@sboshra sboshra Awaiting requested review from sboshra

@ealsur ealsur Awaiting requested review from ealsur

@FabianMeiswinkel FabianMeiswinkel Awaiting requested review from FabianMeiswinkel

@kirillg kirillg Awaiting requested review from kirillg

Assignees
No one assigned
Labels
auto-merge Enables automation to merge PRs QUERY
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adityasa @kirankumarkolli @neildsh