Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding min version requirements for flex consumption #10290

Merged
merged 8 commits into from
Sep 18, 2024
Merged

Conversation

soninaren
Copy link
Member

@soninaren soninaren commented Jul 15, 2024

Issue describing the changes in this PR

Enforcing extension bundle v4 as minimum required version for flex consumption SKU. Using bundle version 4.12.0 as minimum required version as that is the earliest version that is currently used in flex consumption. Also this is the first extension bundle that includes durable version 2.12.0, that has some necessary updates for Flex consumption.

resolves #9478

Pull request checklist

IMPORTANT: Currently, changes must be backported to the in-proc branch to be included in Core Tools and non-Flex deployments.

  • Backporting to the in-proc branch is not required
    • Otherwise: Link to backporting PR
  • My changes do not require documentation changes
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • My changes do not require diagnostic events changes
    • Otherwise: I have added/updated all related diagnostic events and their documentation (Documentation issue linked to PR)
  • I have added all required tests (Unit tests, E2E tests)

Additional information

Additional PR information

Copy link
Member

@fabiocav fabiocav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realize the PR and linked issue mention Flex, but we should avoid SKU specific logic for this. As long as there is a mechanism that enables the environment to configure the rules, the implementation would be SKU agnostic.

src/WebJobs.Script/Description/DotNet/DependencyHelper.cs Outdated Show resolved Hide resolved
@pragnagopa
Copy link
Member

gentle bump on this to prioritize completion to help with FlexConsumption deployment schedules

@soninaren soninaren force-pushed the nasoni/minVersion branch 3 times, most recently from 4efe011 to 4e49614 Compare September 11, 2024 22:41
@soninaren soninaren dismissed fabiocav’s stale review September 18, 2024 17:34

Addressed feedback already

@soninaren soninaren merged commit 3df0573 into dev Sep 18, 2024
10 checks passed
@soninaren soninaren deleted the nasoni/minVersion branch September 18, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enforce V4 bundles as min version of bundles for FC
6 participants