Skip to content

Commit

Permalink
Make socket listener tests more readable. (valkey-io#1027)
Browse files Browse the repository at this point in the history
* Move socket reading into response assert.

This removes reading from socket before asserting on the read value from multiple tests.

* Add helper function to assert on values.

* Remove unused cursor argument.

* Move repeating read logic to function.

* Increase setup legibility.

2-3 booleans in a row are hard to read without confusion. Using enums instead.

* Move repeated writing logic to write helpers.

* Add pointer to value helper function.

* Add another writer helper method.

* fix comments
  • Loading branch information
nihohit authored and cyip10 committed Jun 24, 2024
1 parent 562c832 commit 2065f25
Showing 1 changed file with 323 additions and 201 deletions.
Loading

0 comments on commit 2065f25

Please sign in to comment.