Make socket listener tests more readable. #1027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barshaul
reviewed
Feb 25, 2024
| bool, | ||
| ), | ||
| #[values(true, false)] use_cluster: bool, | ||
| #[values((false, Tls::NoTls), (true, Tls::NoTls), (false,Tls::UseTls))] |
There was a problem hiding this comment.
minor: missing space (false,Tls::UseTls)) -> (false, Tls::UseTls))
barshaul
reviewed
Feb 25, 2024
| bool, | ||
| ), | ||
| #[values(true, false)] use_cluster: bool, | ||
| #[values((false, Tls::NoTls), (true, Tls::NoTls), (false,Tls::UseTls))] |
barshaul
reviewed
Feb 25, 2024
| } | ||
| } | ||
|
|
||
| enum Sharing { |
There was a problem hiding this comment.
'Sharing' still doesn't give enough info for readers - maybe TestServerType, or SharingServer?
barshaul
approved these changes
Feb 25, 2024
This removes reading from socket before asserting on the read value from multiple tests.
2-3 booleans in a row are hard to read without confusion. Using enums instead.
nihohit
force-pushed
the
simplify-tests
branch
from
a395e59
to
8f1b87b
Compare
cyip10
pushed a commit
to Bit-Quill/valkey-glide
that referenced
this pull request
Jun 24, 2024
* Move socket reading into response assert. This removes reading from socket before asserting on the read value from multiple tests. * Add helper function to assert on values. * Remove unused cursor argument. * Move repeating read logic to function. * Increase setup legibility. 2-3 booleans in a row are hard to read without confusion. Using enums instead. * Move repeated writing logic to write helpers. * Add pointer to value helper function. * Add another writer helper method. * fix comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
The tests are made simpler by
setup_basics(true, false, true)is hard to decipher, and requires reading the function's signature in order to understand.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.