Apply root tile scale to tileset geometric error

[lilleyse]

This is related to the problem that was brought up in #5330. As of #8182 we take scale into account when computing a tile's geometric error (see updateGeometricErrorScale) but we don't take scale into account when computing the top-level tileset geometric error.

This can lead to situations where the tileset's geometric error is less than the root tile's geometric error and traversal exits early.

The fix is to scale the tileset's geometric error by the root tile's scale.

[cesium-concierge]

Thanks for the pull request @lilleyse!

• ✔️ Signed CLA found.
• ❔ CHANGES.md was not updated.
  • If this change updates the public API in any way, please add a bullet point to CHANGES.md.
• ❔ Unit tests were not updated.
  • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

• Cesium Viewer works.
• Works in 2D/CV.

[ggetz]

Thanks for the fix, @lilleyse! I tested this out on a tileset where the traversal was exiting early and the issue is resolved.

[jo-chemla]

Cross-posting from the cesium community forum:

I have the same issue, where setting a maximumScreenSpaceError of 0.1 makes it so that my tileset appears at lower zoom levels - and it disappears when this max error is set to simply 1.0. I’m using Cesium version 1.106. Has this fix been merged to the current cesium build? Thanks a lot for getting back!

Looks like the fix indeed has been merged into 1.102, but I’m still seeing this issue. If you’d like a link to the dataset, I can share it privately.

[ggetz]

Hi @jo-chemla, you can send private data to [email protected]. Please include a link to the original post so we know what the context is. Thanks!