Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scale geometric error with tileset #8182

Merged
merged 12 commits into from
Sep 19, 2019
Merged

Scale geometric error with tileset #8182

merged 12 commits into from
Sep 19, 2019

Conversation

hpinkos
Copy link
Contributor

@hpinkos hpinkos commented Sep 19, 2019

Fixes #5330
Fixes #7398

Clean up from #7411

@lilleyse please review

@cesium-concierge
Copy link

Thanks for the pull request @hpinkos!

  • ✔️ Signed CLA found.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@lilleyse
Copy link
Contributor

Looks good! Thanks @hpinkos

@lilleyse lilleyse merged commit 81a3553 into master Sep 19, 2019
@lilleyse lilleyse deleted the scale-geometric-error branch September 19, 2019 14:59
This was referenced Sep 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Matrix4.getRotation returns rotation with scale 3D Tiles scaling does not scale geometric error
4 participants