adding method to convert heading pitch roll in quaternion defined in … #4048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aircraft reference axis (North East Down)
| * var transform = Cesium.Transforms.aircraftHeadingPitchRollToFixedFrame(center, heading, pitch, roll); | ||
| */ | ||
| Transforms.aircraftHeadingPitchRollToFixedFrame = function(origin, heading, pitch, roll, ellipsoid, result) { | ||
| // checks for required parameters happen in the called functions |
There was a problem hiding this comment.
Can you still add unit tests for these with toThrowDeveloperError?
|
Can you update CHANGES.md so users know about these new functions? |
|
@bagnell can you take a quick look at the math? |
|
Thanks again for the pull request, @kaktus40! |
…r to declare the additions
|
I just updated the files following your recommendations. It seems there is some conflicts. |
…ansformations Conflicts: CHANGES.md
|
@pjcozzi Looks good to me. |
pjcozzi
added a commit
that referenced
this pull request
Jun 28, 2016
adding method to convert heading pitch roll in quaternion defined in …
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…aircraft reference axis (North East Down)