Move WebGLConstants from Renderer to Core #4731
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Justification:
Currently we use
WebGLConstants
in Core (ComponentDataType
,IndexDataType
,PixelFormat
,PrimitiveType
, ...), butWebGLConstants
lives in Renderer. MovingWebGLConstants
to Core makes Core completely self contained with no dependencies on the rest of Cesium.This PR also makes
WebGLConstants
public and updates the reference doc for it. We useWebGLConstants
as part of the Cesium API ingltf-pipeline
, so this seemed appropriate.There were also a few members missing
@memberof
declarations in other modules which were being added toglobal
in the doc, so this corrects those as well.