Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move WebGLConstants from Renderer to Core #4731

Merged
merged 12 commits into from
Dec 13, 2016
Merged

Move WebGLConstants from Renderer to Core #4731

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
389cb1d
Moved WebGLConstants from Renderer to Core and updated dependencies
Dec 7, 2016
5d6c88b
Added WebGLConstants and add memberof in a few places to clean the
Dec 8, 2016
ab2b6c4
Merge branch 'master' of github.com:AnalyticalGraphicsInc/cesium into…
Dec 8, 2016
613a12c
Updated CHANGES.md
Dec 8, 2016
fced239
Merge branch 'terrain-mesh-define-fix' of github.com:lasalvavida/cesi…
Dec 8, 2016
396e448
Tweak CHANGES.md
pjcozzi Dec 8, 2016
6374319
Merge branch 'more-define-fixes' of github.com:lasalvavida/cesium int…
Dec 8, 2016
8d25fe7
Merge branch 'master' of github.com:AnalyticalGraphicsInc/cesium into…
Dec 8, 2016
2c80b98
Merge branch 'core-webglconstants' of github.com:lasalvavida/cesium i…
Dec 8, 2016
111faf0
Merge branch 'master' of https:/AnalyticalGraphicsInc/ces…
lasalvavida Dec 13, 2016
be54431
Removed per entry comments and added comment linking to specification
lasalvavida Dec 13, 2016
a2660db
Tweak doc
pjcozzi Dec 13, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ Change Log
* Fixed tooltips for gallery thumbnails in Sandcastle [#4702](https:/AnalyticalGraphicsInc/cesium/pull/4702)
* Fixed `Rectangle.union` to correctly account for rectangles that cross the IDL [#4732](https:/AnalyticalGraphicsInc/cesium/pull/4732).
* Fixed texture rotation for `RectangleGeometry` [#2737](https:/AnalyticalGraphicsInc/cesium/issues/2737)
* Added `WebGLConstants` enum. Previously, this was part of the private Renderer API. [#4731](https:/AnalyticalGraphicsInc/cesium/pull/4731)
* Fixed an bug that caused `GroundPrimitive` to render incorrectly on systems without the `WEBGL_depth_texture` extension. [#4747](https:/AnalyticalGraphicsInc/cesium/pull/4747)

### 1.28 - 2016-12-01
Expand Down
8 changes: 4 additions & 4 deletions Source/Core/ComponentDatatype.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,18 @@
/*global define*/
define([
'../Renderer/WebGLConstants',
'./defaultValue',
'./defined',
'./DeveloperError',
'./FeatureDetection',
'./freezeObject'
'./freezeObject',
'./WebGLConstants'
], function(
WebGLConstants,
defaultValue,
defined,
DeveloperError,
FeatureDetection,
freezeObject) {
freezeObject,
WebGLConstants) {
'use strict';

// Bail out if the browser doesn't support typed arrays, to prevent the setup function
Expand Down
8 changes: 4 additions & 4 deletions Source/Core/IndexDatatype.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,16 @@
/*global define*/
define([
'../Renderer/WebGLConstants',
'./defined',
'./DeveloperError',
'./freezeObject',
'./Math'
'./Math',
'./WebGLConstants'
], function(
WebGLConstants,
defined,
DeveloperError,
freezeObject,
CesiumMath) {
CesiumMath,
WebGLConstants) {
'use strict';

/**
Expand Down
8 changes: 4 additions & 4 deletions Source/Core/PixelFormat.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
/*global define*/
define([
'../Renderer/WebGLConstants',
'./freezeObject'
'./freezeObject',
'./WebGLConstants'
], function(
WebGLConstants,
freezeObject) {
freezeObject,
WebGLConstants) {
'use strict';

/**
Expand Down
8 changes: 4 additions & 4 deletions Source/Core/PrimitiveType.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
/*global define*/
define([
'../Renderer/WebGLConstants',
'./freezeObject'
'./freezeObject',
'./WebGLConstants'
], function(
WebGLConstants,
freezeObject) {
freezeObject,
WebGLConstants) {
'use strict';

/**
Expand Down
11 changes: 7 additions & 4 deletions Source/Renderer/WebGLConstants.js → Source/Core/WebGLConstants.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,15 @@ define([
'use strict';

/**
* WebGL constants.
* Enum containing WebGL Constant values by name.
* for use without an active WebGL context, or in cases where certain constants are unavailable using the WebGL context
* (For example, in [Safari 9]{@link https:/AnalyticalGraphicsInc/cesium/issues/2989}).
*
* This file provides a workaround for Safari 9 where WebGL constants can't be accessed
* through WebGLRenderingContext. See https:/AnalyticalGraphicsInc/cesium/issues/2989
* These match the constants from the [WebGL 1.0]{@link https://www.khronos.org/registry/webgl/specs/latest/1.0/}
* and [WebGL 2.0]{@link https://www.khronos.org/registry/webgl/specs/latest/2.0/}
* specifications.
*
* @private
* @exports WebGLConstants
*/
var WebGLConstants = {
DEPTH_BUFFER_BIT : 0x00000100,
Expand Down
8 changes: 4 additions & 4 deletions Source/Core/WindingOrder.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
/*global define*/
define([
'../Renderer/WebGLConstants',
'./freezeObject'
'./freezeObject',
'./WebGLConstants'
], function(
WebGLConstants,
freezeObject) {
freezeObject,
WebGLConstants) {
'use strict';

/**
Expand Down
Loading