Skip to content
This repository has been archived by the owner on May 10, 2023. It is now read-only.

Localization: Handle Language names #492

Closed
MichaelKohler opened this issue Oct 23, 2021 · 5 comments
Closed

Localization: Handle Language names #492

MichaelKohler opened this issue Oct 23, 2021 · 5 comments
Labels
frontend localization needs discussion P3

Comments

@MichaelKohler
Copy link
Member

CV translates all the language names, we might be able to use that. However we should still show the native name as well.
@MichaelKohler MichaelKohler changed the title Handle Language names Localization: Handle Language names Oct 23, 2021
MichaelKohler added a commit that referenced this issue Oct 31, 2021
@MichaelKohler
fix: show native language name only in stats (issue #492)
ad1fb14
@MichaelKohler
Copy link
Member Author

As of #514 the places where we still show the English and Native name are:

  • "Add" language selection dropdown
  • "Review" language selection dropdown
  • "Profile" language add section dropdown

All these are using the same LanguageSelector. At least for Add and Review it would be fine to only show the native name. For adding a language in the profile it might be fine too, but then we would need everyone to find it by native name, and not by English name. Not sure if that would be good UX?

MichaelKohler added a commit that referenced this issue Oct 31, 2021
@MichaelKohler
fix: show native language name only in stats (issue #492) (#514)
0086c64
MichaelKohler pushed a commit that referenced this issue Oct 31, 2021
@semantic-release-bot
chore(release): 2.12.0
e83dc4e 
# [2.12.0](v2.11.3...v2.12.0) (2021-10-31)

### Bug Fixes

* always link to localized URL (fixes [#504](#504)) ([#512](#512)) ([6e66528](6e66528))
* do not use locale prefixed URLs for login/logout ([#506](#506)) ([02053a4](02053a4))
* fix empty page after reviewing last sentence (fixes [#498](#498)) ([728f429](728f429))
* fix typo in sc-lang-info-left-for-you ([#515](#515)) ([313273f](313273f))
* fix upperkey keys not working in Review (fixes [#487](#487)) ([#508](#508)) ([6c3a073](6c3a073))
* make duplicate sentences use plural rules ([#511](#511)) ([ab2c696](ab2c696))
* move LocalizationProvider outwards to not request language on every page navigation ([6a5967e](6a5967e))
* only expose error codes ([2114b38](2114b38))
* show 'Add more sentences' link in stats when no more to review for user ([#516](#516)) ([ae9f1cf](ae9f1cf))
* show native language name only in stats (issue [#492](#492)) ([#514](#514)) ([0086c64](0086c64))
* slight font adjustments ([#505](#505)) ([25ca2e0](25ca2e0))

### Features

* localization: extract English strings into FTL file ([#507](#507)) ([6d64afb](6d64afb)), closes [#501](#501)
@MichaelKohler
Copy link
Member Author

I think this doesn't block the release of localization and can be followed up upon later on. For now the only English name left is in the "Add language" language selector dropdown. While this is not great, we need to figure out how we can handle all the language names. Common Voice already has translations for some languages, but Sentence Collector has a few languages that are not yet enabled on Common Voice. But maybe that indeed is the problem itself. We will need to discuss this.

@MichaelKohler MichaelKohler added P3 and removed P2 labels Nov 10, 2021
@HarikalarKutusu
Copy link
Contributor

If there is no hindrance, I would suggest putting the sentences to Pontoon. Translation + accept process in Pontoon will take quite a few time,

Sentence Collector has a few languages that are not yet enabled on Common Voice. But maybe that indeed is the problem itself. We will need to discuss this.

IMHO this is normal per the New Language process.
If there are languages in SC that are not in Pontoon that would be not normal.
I think keeping Pontoon & SC in parallel would be a good idea for these.

@MichaelKohler MichaelKohler mentioned this issue Nov 11, 2021
Closed
2 tasks
@MichaelKohler
Copy link
Member Author

I've created #531 to handle that initial discussion.

@MichaelKohler
Copy link
Member Author

I'm closing this as this will eventually be handled with #534. Until then I think we're fine.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
frontend localization needs discussion P3
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MichaelKohler @HarikalarKutusu