Remove @pipeline tag on feature tests for PRs
#3574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…think such restrictions are necessary. We originally had this restriction because some of the feature tests were flakey but this is no longer the case. When we merge a PR it will run all the tests anyway so there is no point having PRs that pass but then release that fail due to a missed change. This will make PRs a bit longer but that should be fine.
tim-s-ccs
force-pushed
the
remove-pipeline-tag-and-run-all-feature-test
branch
from
263aabc
to
58be799
Compare
Chee-Ng
approved these changes
Mar 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I’ve removed the pipeline restrictions for feature tests as I do not think such restrictions are necessary. We originally had this restriction because some of the feature tests were flakey but this is no longer the case.
When we merge a PR it will run all the tests anyway so there is no point having PRs that pass but then release that fail due to a missed change. This will make PRs a bit longer but that should be fine.