Add csv file support and solve issues #26, #21, #20, #19, and #24 #41
Conversation
… jacobi functions
…ed tests accordingly. Additionally, \sinh x was moved to the semantic-latex.json file.
| .option('--usemathrm', 'Use \\mathrm instead of \\mbox to escape some text literals') | ||
| .option('--usemhchem', 'Allow commands from the mhchem package') | ||
| .option('-D, --debug', 'Show stack trace on failure'); | ||
| .option('--semanticLaTeX', 'Include semantic LaTeX') |
There was a problem hiding this comment.
text for options should be all lower case, e.g., --semanticlatex instead of --semanticLaTeX
|
👍 Nice. Just some minor comments inline |
|
@ClaudeZou It's not elliptical Jacobi functions. It's Jacobi elliptic functions. That's very different and wrong the way you wrote it. |
| @@ -166,6 +179,10 @@ lit | |||
| / name:FUN_AR2 l1:lit l2:lit { return ast.Tex.FUN2(name, l1, l2); } | |||
| / name:FUN_AR2nb l1:lit l2:lit { return ast.Tex.FUN2nb(name, l1, l2); } | |||
| / name:FUN_AR3 l1:lit l2:lit l3:lit { return ast.Tex.FUN3(name, l1, l2, l3); } | |||
| / f:JACOBI l1:lit l2:lit l3:lit atsymbol l4:lit &{ return options.semanticLaTeX; } { return ast.Tex.JACOBI(l1, l2, l3, l4); } | |||
There was a problem hiding this comment.
This is the part of the code which verifies that the input tex is correct. Somehow, this needs to be generated from the csv input.
|
@ClaudeZou @notjagan Note that my comments about csv parsing do not have to do with the current merge and are ideas just about where to go in the 'near' future. On the other hand, @notjagan needs to be working on moving all 'replacement' efforts into the texer repo. With emphasis on getting all function specific information from the csv file. |
|
Fixes #35 and some of the problems mentioned |
|
ok. let's merge |
No description provided.