-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[lambda] Add lambda flare
subcommand
#979
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-initial [lambda][flare] Add initial code for Lambda serverless flare
* Create and validate flare flags * Write config to file and zip it * - Send zip to Datadog when not in dry run * Change zip method to use the `jszip` package for compatability on Windows, Mac, and Linux * Add `jszip` copyright * - Move constant endpoints - Remove redundant try/catch on `fs.createReadStream` since the higher-level function `execute` handles the error - Remove redundant `.then()` since we already use `await` * Get CLI version programmatically and set as `operator_version` * Rename `operator_version` to `datadog_ci_version` * Code review refactoring * Create thorough tests
* Create and validate flare flags * Write config to file and zip it * - Send zip to Datadog when not in dry run * Change zip method to use the `jszip` package for compatability on Windows, Mac, and Linux * Add `jszip` copyright * - Move constant endpoints - Remove redundant try/catch on `fs.createReadStream` since the higher-level function `execute` handles the error - Remove redundant `.then()` since we already use `await` * Get CLI version programmatically and set as `operator_version` * Rename `operator_version` to `datadog_ci_version` * Code review refactoring * Create thorough tests
…i into serverless-flare
Add `--with-logs` flag, which gets logs from the last 3 AWS CloudWatch Streams
…i into serverless-flare
Obfuscate secrets
…port (#953) * Prompt before sending to support
Add human readable timestamp as a column in the CSV file
Refactor flags validations
Get resource tags and save in `tags.json`
Use `DATADOG_SITE` and `DD_SITE` environment variables to build endpoint URL
duncanista
changed the title
Add lambda flare command
[lambda] Add Jul 12, 2023
lambda flare
subcommand
Datadog ReportBranch report: ✅ |
duncanista
approved these changes
Jul 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving directly.
All previous reviews are combined into this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
Add
lambda flare
command to automatically collect useful information from customers to help Datadog support resolve customer issues.How?
#924 Get and send AWS configuration for a single lambda function
#941 Collect CloudWatch logs and save in the
logs
folder#947 Obfuscate secrets in AWS function configuration
#953 Ask for user confirmation before sending zip file to support
#954 Add human readable timestamp to CSV files for logs
#958 Refactor flag validation
#955 Get resource tags for the Lambda function and save in
tags.json
#967 Build endpoint URL from Datadog site environment variables for lower latency when sending zip file:
#973 Don't require email or case ID as flags when running in dry mode
#960 Add optional start/end flags for CloudWatch logs. Only collect log events that fall inside that time range
#978 Update config obfuscation to use shared functions in
commons.ts
#980 Remove unused constants
#981 Update site endpoints to append
app.
when no subdomain is included.Review checklist