Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lambda][flare] Update site endpoints #981

Merged

Conversation

nhulston
Copy link
Contributor

@nhulston nhulston commented Jul 12, 2023

What and why?

Due to a DNS inconsistency, the lambda flare endpoint doesn't work on sites with no subdomain (for example, US1).
This PR updates sites to append endpoint URL with app. when no subdomain is present in the original URL.

How?

if ([DATADOG_SITE_US1, DATADOG_SITE_EU1, DATADOG_SITE_GOV].includes(baseUrl)) {
  endpointUrl = 'app.' + baseUrl
}

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
    Snapshots have been updated to handle this change

@datadog-datadog-prod-us1
Copy link

Datadog Report

Branch report: nicholas.hulston/serverless-flare/update-sites
Commit report: 92f64cc

datadog-ci-tests: 0 Failed, 0 New Flaky, 873 Passed, 0 Skipped, 59.29s Wall Time

@nhulston nhulston marked this pull request as ready for review July 12, 2023 20:51
@nhulston nhulston requested a review from a team as a code owner July 12, 2023 20:51
@nhulston nhulston merged commit 1da3ea4 into serverless-flare Jul 12, 2023
10 checks passed
@nhulston nhulston deleted the nicholas.hulston/serverless-flare/update-sites branch July 12, 2023 20:53
@duncanista duncanista mentioned this pull request Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants