Set 'env' to 'none' if not set or empty #4765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikita-tkachenko-datadog
added
comp: ci visibility
smola
reviewed
Feb 21, 2023
| "" | TraceUtils.DEFAULT_SERVICE_NAME | ||
| "good" | "good" | ||
| "bad\$service" | "bad_service" | ||
| service | expected |
There was a problem hiding this comment.
Unless there's an actual required change here, or spotless is complaining in CI, it's better to avoid unrelated formatting changes in PRs.
There was a problem hiding this comment.
Good point!
I think the Save Actions plugin config suggested in our contributing guide is too "eager".
I had to change Reformat file to Reformat only changed code to get rid of the extra changes
nikita-tkachenko-datadog
force-pushed
the
nikita-tkachenko/fix-default-env-value
branch
from
0293a1b
to
11f5085
Compare
albertvaka
approved these changes
Feb 22, 2023
nikita-tkachenko-datadog
deleted the
nikita-tkachenko/fix-default-env-value
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
This change updates span data normalisation logic used by DD Intake writer (i.e. in configurations where the tracer writes directly to backend, with no DD Agent involved).
The logic is updated so that
envtag is set tononeif no other value is provided for it (or if provided value is empty).Motivation
This was requested by the backend.
Additional Notes
Normally this data normalisation is done by the agent, but in configurations where the tracer writes directly to the backend, it has to be replicated in the tracer.