Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude click 8.1.4 to solve mypy issues #15201

Merged
merged 1 commit into from
Jul 10, 2023
Merged

Exclude click 8.1.4 to solve mypy issues #15201

merged 1 commit into from
Jul 10, 2023

Conversation

FlorentClarret
Copy link
Member

@FlorentClarret FlorentClarret commented Jul 7, 2023 •
edited
Loading

What does this PR do?

Exclude click 8.1.4 to solve mypy issues

Motivation

pallets/click#2558

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached
  • If the PR doesn't need to be tested during QA, please add a qa/skip-qa label.

@ghost ghost added the dev_package label Jul 7, 2023
@github-actions
Copy link

github-actions bot commented Jul 7, 2023 •
edited
Loading

Test Results

       6 files         6 suites   17m 16s ⏱️
   676 tests    671 ✔️   5 💤 0 ❌
1 452 runs  1 399 ✔️ 53 💤 0 ❌

Results for commit 761f412.

♻️ This comment has been updated with latest results.

@FlorentClarret FlorentClarret force-pushed the florentclarret/ddev/mypy_issues branch 3 times, most recently from c09d81b to 3629a42 Compare July 7, 2023 12:32
@ghost ghost added the ddev label Jul 7, 2023
@FlorentClarret FlorentClarret force-pushed the florentclarret/ddev/mypy_issues branch from 3629a42 to 22fe5cf Compare July 7, 2023 12:34
@FlorentClarret FlorentClarret changed the title Attempt to fix mypy issues Exclude click 8.1.4 to solve mypy issues Jul 7, 2023
@FlorentClarret FlorentClarret marked this pull request as ready for review July 7, 2023 12:38
@FlorentClarret FlorentClarret requested a review from a team as a code owner July 7, 2023 12:38
@codecov
Copy link

codecov bot commented Jul 7, 2023 •
edited
Loading

Codecov Report

Merging #15201 (761f412) into master (40f67d1) will increase coverage by 0.00%.
The diff coverage is n/a.

Flag Coverage Δ
datadog_checks_dev 82.77% <ø> (+0.07%) ⬆️
ddev 99.24% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@FlorentClarret FlorentClarret force-pushed the florentclarret/ddev/mypy_issues branch from 22fe5cf to 761f412 Compare July 7, 2023 12:43
yzhan289
yzhan289 reviewed Jul 7, 2023
View reviewed changes
ddev/hatch.toml
@@ -3,6 +3,10 @@ check-types = true
mypy-args = [
"src/ddev",
]
# TODO remove once https:/pallets/click/issues/2558 is solved
mypy-deps = [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q: Where does mypy-deps get used?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There

integrations-core/ddev/src/ddev/plugin/external/hatch/environment_collector.py

Lines 30 to 32 in 96309a6

@cached_property
def mypy_args(self):
return self.config.get('mypy-args', [])

@FlorentClarret FlorentClarret merged commit 411e4e4 into master Jul 10, 2023
49 checks passed
@FlorentClarret FlorentClarret deleted the florentclarret/ddev/mypy_issues branch July 10, 2023 07:35
ofek added a commit that referenced this pull request Jul 13, 2023
@ofek
Revert "Exclude click 8.1.4 to solve mypy issues (#15201)"
e8a7b9e 
This reverts commit 411e4e4.
ofek added a commit that referenced this pull request Jul 19, 2023
@ofek @FlorentClarret
Upgrade click to 8.1.6 (#15272)
b13cdaa 
* Revert "Exclude click 8.1.4 to solve mypy issues (#15201)"

This reverts commit 411e4e4.

* Upgrade click to 8.1.5

* Apply suggestions from code review

Co-authored-by: Florent Clarret <[email protected]>

---------

Co-authored-by: Florent Clarret <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yzhan289 yzhan289 yzhan289 left review comments

@ofek ofek ofek approved these changes

Assignees
No one assigned
Labels
ddev dev_package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FlorentClarret @ofek @yzhan289