Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade click to 8.1.6 #15272

Merged
merged 4 commits into from
Jul 19, 2023
Merged

Upgrade click to 8.1.6 #15272

merged 4 commits into from
Jul 19, 2023

Conversation

ofek
Copy link
Contributor

@ofek ofek commented Jul 13, 2023

Motivation

pallets/click#2558 (comment)

Additional Notes

We use Mypy so we should be fine (this is regarding the subsequent comment)

@ofek ofek requested a review from a team as a code owner July 13, 2023 15:31
FlorentClarret
FlorentClarret previously approved these changes Jul 13, 2023
View reviewed changes
Copy link
Member

@FlorentClarret FlorentClarret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@codecov
Copy link

codecov bot commented Jul 13, 2023 •
edited
Loading

Codecov Report

Merging #15272 (90acfed) into master (d25ae2d) will increase coverage by 0.09%.
The diff coverage is n/a.

Flag Coverage Δ
datadog_checks_dev 82.62% <ø> (+0.03%) ⬆️
ddev 99.25% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@github-actions
Copy link

github-actions bot commented Jul 13, 2023 •
edited
Loading

Test Results

       6 files         6 suites   8m 9s ⏱️
   678 tests    673 ✔️   5 💤 0 ❌
1 456 runs  1 403 ✔️ 53 💤 0 ❌

Results for commit 90acfed.

♻️ This comment has been updated with latest results.

FlorentClarret
FlorentClarret reviewed Jul 19, 2023
View reviewed changes
ddev/pyproject.toml Outdated Show resolved Hide resolved
@ofek ofek changed the title Upgrade click to 8.1.5 Upgrade click to 8.1.6 Jul 19, 2023
@ofek ofek merged commit b13cdaa into master Jul 19, 2023
39 checks passed
@ofek ofek deleted the ofek/u branch July 19, 2023 20:06
@vivek-datadog vivek-datadog added the qa/skip-qa Automatically skip this PR for the next QA label Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FlorentClarret FlorentClarret FlorentClarret left review comments

Assignees
No one assigned
Labels
ddev dev_package qa/skip-qa Automatically skip this PR for the next QA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ofek @FlorentClarret @vivek-datadog