Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce a configurable limit on the number of DNS records per user #110

Closed
humphd opened this issue Feb 3, 2023 · 1 comment · Fixed by #384
Closed

Enforce a configurable limit on the number of DNS records per user #110

humphd opened this issue Feb 3, 2023 · 1 comment · Fixed by #384
Assignees
Labels
area: functionality Back end microservices that contribute to our main functionality category: DNS A service about hosting domains discussion Please tell us what you think!

Comments

@humphd
Copy link
Contributor

humphd commented Feb 3, 2023

We need to be able to set an environment variable that imposes a limit on the number of DNS records a user can have. When the user tries to add a new record, their current record count should be compared against this limit, and the operation should fail if it will mean exceeding the limit.

I'm not sure what the right way to enforce this is (e.g., in the db, in the model code, etc).

@sirinoks sirinoks added area: functionality Back end microservices that contribute to our main functionality category: DNS A service about hosting domains discussion Please tell us what you think! labels Feb 13, 2023
@Genne23v Genne23v self-assigned this Feb 24, 2023
@Genne23v
Copy link
Contributor

In my opinion, if model declines the request, queue will continuously request although there is no second chance to make it happen. I think the dns worker should throw UnrecoverableError. Please let me know if it sounds like a plan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: functionality Back end microservices that contribute to our main functionality category: DNS A service about hosting domains discussion Please tell us what you think!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants