Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit the number of records per user #384

Merged
merged 1 commit into from
Mar 20, 2023
Merged

Limit the number of records per user #384

merged 1 commit into from
Mar 20, 2023

Conversation

Genne23v
Copy link
Contributor

Close #110

  • This PR will limit the user to have more than the configurable number of records.
  • This configurable number is set as MAX_USER_RECORD_LIMIT in .env
  • If MAX_USER_RECORD_LIMIT is not set, 5 will be stored in MAX_USER_RECORD_LIMIT

@Genne23v Genne23v added this to the Milestone 0.7 milestone Mar 19, 2023
@Genne23v Genne23v self-assigned this Mar 19, 2023
humphd
humphd requested changes Mar 20, 2023
View reviewed changes
Copy link
Contributor

@humphd humphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice simple fix!

.env.example Outdated Show resolved Hide resolved
app/models/record.server.ts Outdated Show resolved Hide resolved
.env.example Outdated Show resolved Hide resolved
humphd
humphd previously approved these changes Mar 20, 2023
View reviewed changes
@SerpentBytes SerpentBytes self-requested a review March 20, 2023 01:23
SerpentBytes
SerpentBytes previously approved these changes Mar 20, 2023
View reviewed changes
@Genne23v Genne23v dismissed stale reviews from SerpentBytes and humphd via 0797642 March 20, 2023 14:54
@Genne23v Genne23v merged commit 576712b into DevelopingSpace:main Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@humphd humphd humphd approved these changes

@Ririio Ririio Ririio approved these changes

@SerpentBytes SerpentBytes SerpentBytes left review comments

Assignees

@Genne23v Genne23v

Labels
None yet
Projects
None yet
Milestone
Milestone 0.7
Development

Successfully merging this pull request may close these issues.

Enforce a configurable limit on the number of DNS records per user
4 participants
@Genne23v @humphd @Ririio @SerpentBytes