-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
merge #8
merge #8
Commits on Oct 22, 2019
-
Configuration menu - View commit details
-
Copy full SHA for f0878b4 - Browse repository at this point
Copy the full SHA f0878b4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 379580a - Browse repository at this point
Copy the full SHA 379580aView commit details
Commits on Nov 4, 2019
-
tests/resource/aws_batch_job_queue: Remove sweeper prefix checking (#…
…10709) Previously, resource sweepers were implemented with name prefix checking to potentially allow them to run more safely in accounts with other active resources. In practice though, this was unmaintainable across the community contributed test configurations so sweepers were then made to be wholly responsible for cleaning up a resource within an account. This appears to be a place where that prefix checking was not removed, which causes issues with sweeping `aws_batch_compute_environment` resources: ```console $ go test ./aws -v -timeout=10h -sweep=us-west-2 -sweep-run=aws_batch_job_queue,aws_batch_compute_environment -sweep-allow-failures 2019/11/01 09:25:58 [DEBUG] Running Sweepers for region (us-west-2): 2019/11/01 09:25:58 [DEBUG] Sweeper (aws_batch_compute_environment) has dependency (aws_batch_job_queue), running.. ... 2019/11/01 09:26:00 [INFO] Skipping Batch Job Queue: tf_batch_target-2680393626223669634 2019/11/01 09:26:00 [DEBUG] Running Sweeper (aws_batch_compute_environment) in region (us-west-2) ... 2019/11/01 09:26:02 [INFO] Deleting Batch Compute Environment: tf_batch_target-2680393626223669634 2019/11/01 09:26:02 [ERROR] Failed to delete Batch Compute Environment tf_batch_target-2680393626223669634: : Cannot delete, found existing JobQueue relationship ``` Output from sweepers after update: ```console $ go test ./aws -v -timeout=10h -sweep=us-west-2 -sweep-run=aws_batch_job_queue,aws_batch_compute_environment -sweep-allow-failures 2019/11/01 09:32:01 [DEBUG] Running Sweepers for region (us-west-2): 2019/11/01 09:32:01 [DEBUG] Sweeper (aws_batch_compute_environment) has dependency (aws_batch_job_queue), running.. ... 2019/11/01 09:32:03 [INFO] Disabling Batch Job Queue: tf_batch_target-2680393626223669634 2019/11/01 09:32:04 [DEBUG] Waiting for state to become: [VALID] 2019/11/01 09:32:14 [INFO] Deleting Batch Job Queue: tf_batch_target-2680393626223669634 2019/11/01 09:32:15 [DEBUG] Waiting for state to become: [DELETED] 2019/11/01 09:32:25 [DEBUG] Job Queue "tf_batch_target-2680393626223669634" is already gone 2019/11/01 09:32:25 [DEBUG] Running Sweeper (aws_batch_compute_environment) in region (us-west-2) ... 2019/11/01 09:32:27 [INFO] Deleting Batch Compute Environment: tf_batch_target-2680393626223669634 2019/11/01 09:32:28 [DEBUG] Waiting for state to become: [DELETED] 2019/11/01 09:32:29 [TRACE] Waiting 5s before next try 2019/11/01 09:32:34 [DEBUG] Sweeper (aws_batch_job_queue) already ran in region (us-west-2) 2019/11/01 09:32:34 Sweeper Tests ran successfully: - aws_batch_job_queue - aws_batch_compute_environment ok github.com/terraform-providers/terraform-provider-aws/aws 34.796s ```
Configuration menu - View commit details
-
Copy full SHA for 1bb5073 - Browse repository at this point
Copy the full SHA 1bb5073View commit details -
Configuration menu - View commit details
-
Copy full SHA for d4b69da - Browse repository at this point
Copy the full SHA d4b69daView commit details -
d/aws_route53_resolver_rule: Don't retrieve tags for rules 'SHARED_WI…
…TH_ME'. (#10348) Output from acceptance testing: ``` --- PASS: TestAccDataSourceAwsRoute53ResolverRule_basic (29.29s) --- PASS: TestAccDataSourceAwsRoute53ResolverRule_ResolverEndpointIdWithTags (194.42s) --- PASS: TestAccDataSourceAwsRoute53ResolverRule_SharedByMe (192.54s) --- PASS: TestAccDataSourceAwsRoute53ResolverRules_basic (7.87s) --- PASS: TestAccDataSourceAwsRoute53ResolverRule_SharedWithMe (185.97s) --- PASS: TestAccDataSourceAwsRoute53ResolverRules_ResolverEndpointId (193.63s) ```
Configuration menu - View commit details
-
Copy full SHA for 28038b2 - Browse repository at this point
Copy the full SHA 28038b2View commit details -
Configuration menu - View commit details
-
Copy full SHA for c786323 - Browse repository at this point
Copy the full SHA c786323View commit details -
resource/aws_rds_cluster: Refactor tagging to use keyvaluetags library (
#10483) Output from acceptance testing (testing failures unrelated): ``` --- PASS: TestAccAWSRDSClusterInstance_namePrefix (615.04s) --- PASS: TestAccAWSRDSClusterInstance_CopyTagsToSnapshot (697.46s) --- PASS: TestAccAWSRDSClusterInstance_PerformanceInsightsEnabled_AuroraPostgresql (732.32s) --- PASS: TestAccAWSRDSClusterInstance_az (732.74s) --- PASS: TestAccAWSRDSClusterInstance_disappears (736.33s) --- PASS: TestAccAWSRDSClusterInstance_PerformanceInsightsEnabled_AuroraMysql1 (752.13s) --- PASS: TestAccAWSRDSClusterInstance_kmsKey (781.41s) --- PASS: TestAccAWSRDSClusterInstance_generatedName (784.35s) --- PASS: TestAccAWSRDSClusterInstance_PerformanceInsightsKmsKeyId_AuroraMysql1 (792.55s) --- PASS: TestAccAWSRDSClusterInstance_PerformanceInsightsKmsKeyId_AuroraMysql2_DefaultKeyToCustomKey (836.28s) --- PASS: TestAccAWSRDSClusterInstance_PerformanceInsightsKmsKeyId_AuroraMysql2 (843.00s) --- PASS: TestAccAWSRDSCluster_missingUserNameCausesError (3.37s) --- PASS: TestAccAWSRDSCluster_basic (119.62s) --- PASS: TestAccAWSRDSCluster_AvailabilityZones (120.42s) --- PASS: TestAccAWSRDSClusterInstance_PerformanceInsightsKmsKeyId_AuroraMysql1_DefaultKeyToCustomKey (856.65s) --- PASS: TestAccAWSRDSClusterInstance_PubliclyAccessible (858.62s) --- PASS: TestAccAWSRDSClusterInstance_PerformanceInsightsEnabled_AuroraMysql2 (863.08s) --- PASS: TestAccAWSRDSCluster_BacktrackWindow (144.43s) --- PASS: TestAccAWSRDSCluster_ClusterIdentifierPrefix (129.29s) --- PASS: TestAccAWSRDSCluster_DbSubnetGroupName (113.02s) --- PASS: TestAccAWSRDSClusterInstance_MonitoringRoleArn_RemovedToEnabled (910.20s) --- PASS: TestAccAWSRDSCluster_generatedName (129.29s) --- PASS: TestAccAWSRDSCluster_Tags (109.66s) --- PASS: TestAccAWSRDSCluster_takeFinalSnapshot (140.03s) --- PASS: TestAccAWSRDSCluster_encrypted (119.31s) --- PASS: TestAccAWSRDSCluster_kmsKey (138.51s) --- PASS: TestAccAWSRDSClusterInstance_MonitoringRoleArn_EnabledToRemoved (1001.55s) --- PASS: TestAccAWSRDSClusterInstance_MonitoringRoleArn_EnabledToDisabled (1014.31s) --- PASS: TestAccAWSRDSCluster_updateIamRoles (166.13s) --- PASS: TestAccAWSRDSCluster_iamAuth (129.62s) --- PASS: TestAccAWSRDSCluster_backupsUpdate (144.39s) --- PASS: TestAccAWSRDSCluster_copyTagsToSnapshot (180.30s) --- PASS: TestAccAWSRDSCluster_DeletionProtection (134.65s) --- PASS: TestAccAWSRDSCluster_EngineMode_Global (130.18s) --- PASS: TestAccAWSRDSCluster_EngineMode_Multimaster (123.49s) --- PASS: TestAccAWSRDSCluster_EngineVersion (131.61s) --- PASS: TestAccAWSRDSCluster_EngineMode_ParallelQuery (149.45s) --- PASS: TestAccAWSRDSCluster_EnabledCloudwatchLogsExports (316.41s) --- SKIP: TestAccAWSRDSCluster_SnapshotIdentifier_EngineMode_Serverless (0.00s) --- FAIL: TestAccAWSRDSCluster_EngineMode (269.83s) --- PASS: TestAccAWSRDSClusterEndpoint_basic (1199.79s) --- PASS: TestAccAWSRDSCluster_Port (245.86s) --- PASS: TestAccAWSRDSClusterInstance_MonitoringInterval (1330.13s) --- PASS: TestAccAWSRDSCluster_ScalingConfiguration (329.07s) --- PASS: TestAccAWSRDSClusterInstance_basic (1394.46s) --- PASS: TestAccAWSRDSCluster_SnapshotIdentifier (327.15s) --- PASS: TestAccAWSRDSClusterInstance_PerformanceInsightsKmsKeyId_AuroraPostgresql_DefaultKeyToCustomKey (739.93s) --- PASS: TestAccAWSRDSClusterInstance_PerformanceInsightsKmsKeyId_AuroraPostgresql (827.55s) --- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_EngineMode_Provisioned (347.17s) --- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_DeletionProtection (393.05s) --- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_EngineMode_ParallelQuery (407.94s) --- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_MasterPassword (337.06s) --- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_EngineVersion_Different (387.04s) --- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_EngineVersion_Equal (407.20s) --- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_MasterUsername (327.23s) --- FAIL: TestAccAWSRDSCluster_SnapshotIdentifier_PreferredBackupWindow (303.76s) --- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_PreferredMaintenanceWindow (326.91s) --- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_Tags (347.21s) --- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_VpcSecurityGroupIds (328.19s) --- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_EncryptedRestore (317.03s) --- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_VpcSecurityGroupIds_Tags (348.14s) --- PASS: TestAccAWSRDSCluster_EngineVersionWithPrimaryInstance (1094.88s) --- FAIL: TestAccAWSRDSCluster_s3Restore (1491.68s) --- PASS: TestAccAWSRDSCluster_EncryptedCrossRegionReplication (1474.46s) --- FAIL: TestAccAWSRDSCluster_GlobalClusterIdentifier_Remove (2984.93s) --- FAIL: TestAccAWSRDSCluster_GlobalClusterIdentifier (3146.46s) --- FAIL: TestAccAWSRDSCluster_GlobalClusterIdentifier_Add (3152.06s) --- FAIL: TestAccAWSRDSCluster_GlobalClusterIdentifier_Update (3219.22s) ```
Configuration menu - View commit details
-
Copy full SHA for af329f3 - Browse repository at this point
Copy the full SHA af329f3View commit details -
Add Tag Support to API Gateway VPC Link Resource (#10561)
Output from acceptance testing: ``` --- PASS: TestAccAWSAPIGatewayVpcLink_basic (700.66s) --- PASS: TestAccAWSAPIGatewayVpcLink_tags (726.60s) ```
Configuration menu - View commit details
-
Copy full SHA for 840ba76 - Browse repository at this point
Copy the full SHA 840ba76View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4e3f47a - Browse repository at this point
Copy the full SHA 4e3f47aView commit details -
Add Tag Support to API Gateway Client Certificate Resource (#10569)
Output from acceptance testing: ``` --- PASS: TestAccAWSAPIGatewayClientCertificate_basic (13.36s) --- PASS: TestAccAWSAPIGatewayClientCertificate_tags (18.58s) ```
Configuration menu - View commit details
-
Copy full SHA for 600cbeb - Browse repository at this point
Copy the full SHA 600cbebView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5eb3b4f - Browse repository at this point
Copy the full SHA 5eb3b4fView commit details -
Refactor code_build_project to use keyvaluetags (#10701)
Output from acceptance testing (failure unrelated): ``` --- FAIL: TestAccAWSCodeBuildProject_Source_Auth (13.49s) --- PASS: TestAccAWSCodeBuildProject_BadgeEnabled (38.27s) --- PASS: TestAccAWSCodeBuildProject_basic (38.19s) --- PASS: TestAccAWSCodeBuildProject_Source_Type_CodeCommit (39.78s) --- PASS: TestAccAWSCodeBuildProject_Source_Type_Bitbucket (41.42s) --- PASS: TestAccAWSCodeBuildProject_Source_Type_CodePipeline (41.70s) --- PASS: TestAccAWSCodeBuildProject_Environment_Certificate (41.71s) --- PASS: TestAccAWSCodeBuildProject_Source_Type_GitHubEnterprise (34.23s) --- PASS: TestAccAWSCodeBuildProject_BuildTimeout (51.64s) --- PASS: TestAccAWSCodeBuildProject_Source_ReportBuildStatus_GitHub (51.58s) --- PASS: TestAccAWSCodeBuildProject_Source_InsecureSSL (52.77s) --- PASS: TestAccAWSCodeBuildProject_Source_GitCloneDepth (53.02s) --- PASS: TestAccAWSCodeBuildProject_Environment_EnvironmentVariable_Type (53.02s) --- PASS: TestAccAWSCodeBuildProject_Source_ReportBuildStatus_Bitbucket (53.18s) --- PASS: TestAccAWSCodeBuildProject_Description (54.12s) --- PASS: TestAccAWSCodeBuildProject_Source_ReportBuildStatus_GitHubEnterprise (54.36s) --- PASS: TestAccAWSCodeBuildProject_EncryptionKey (57.44s) --- PASS: TestAccAWSCodeBuildProject_LogsConfig_CloudWatchLogs (58.29s) --- PASS: TestAccAWSCodeBuildProject_Source_Type_NoSourceInvalid (19.16s) --- PASS: TestAccAWSCodeBuildProject_LogsConfig_S3Logs (63.05s) --- PASS: TestAccAWSCodeBuildProject_Environment_EnvironmentVariable (63.43s) --- PASS: TestAccAWSCodeBuildProject_Source_Type_NoSource (30.84s) --- SKIP: TestAccAWSCodeBuildProject_SecondaryArtifacts_Name (0.00s) --- PASS: TestAccAWSCodeBuildProject_Source_Type_S3 (33.54s) --- PASS: TestAccAWSCodeBuildProject_WindowsContainer (31.92s) --- PASS: TestAccAWSCodeBuildProject_Artifacts_ArtifactIdentifier (30.07s) --- PASS: TestAccAWSCodeBuildProject_Tags (42.74s) --- PASS: TestAccAWSCodeBuildProject_Artifacts_Location (35.90s) --- PASS: TestAWSCodeBuildProject_nameValidation (0.00s) --- PASS: TestAccAWSCodeBuildProject_SecondaryArtifacts (33.51s) --- PASS: TestAccAWSCodeBuildProject_Cache (91.27s) --- PASS: TestAccAWSCodeBuildProject_Artifacts_EncryptionDisabled (47.09s) --- PASS: TestAccAWSCodeBuildProject_Artifacts_Name (46.26s) --- PASS: TestAccAWSCodeBuildProject_Artifacts_Packaging (46.90s) --- PASS: TestAccAWSCodeBuildProject_Artifacts_Type (46.24s) --- PASS: TestAccAWSCodeBuildProject_Artifacts_Path (46.87s) --- PASS: TestAccAWSCodeBuildProject_Artifacts_NamespaceType (48.23s) --- PASS: TestAccAWSCodeBuildProject_Artifacts_OverrideArtifactName (47.90s) --- PASS: TestAccAWSCodeBuildProject_VpcConfig (59.50s) --- PASS: TestAccAWSCodeBuildProject_SecondaryArtifacts_ArtifactIdentifier (43.39s) --- PASS: TestAccAWSCodeBuildProject_SecondaryArtifacts_OverrideArtifactName (43.98s) --- PASS: TestAccAWSCodeBuildProject_SecondaryArtifacts_EncryptionDisabled (42.45s) --- PASS: TestAccAWSCodeBuildProject_SecondaryArtifacts_Location (42.90s) --- PASS: TestAccAWSCodeBuildProject_SecondaryArtifacts_Type (30.71s) --- PASS: TestAccAWSCodeBuildProject_SecondarySources_CodeCommit (23.96s) --- PASS: TestAccAWSCodeBuildProject_SecondaryArtifacts_NamespaceType (41.06s) --- PASS: TestAccAWSCodeBuildProject_SecondaryArtifacts_Packaging (38.87s) --- PASS: TestAccAWSCodeBuildProject_SecondaryArtifacts_Path (37.74s) --- PASS: TestAccAWSCodeBuildProject_Environment_RegistryCredential (36.86s) ```
Configuration menu - View commit details
-
Copy full SHA for 2a08ad7 - Browse repository at this point
Copy the full SHA 2a08ad7View commit details -
Add Tag Support to Storage Gateway NFS File Share Resource (#10722)
``` --- PASS: TestAccAWSStorageGatewayNfsFileShare_basic (256.85s) --- PASS: TestAccAWSStorageGatewayNfsFileShare_KMSEncrypted (277.85s) --- PASS: TestAccAWSStorageGatewayNfsFileShare_GuessMIMETypeEnabled (292.84s) --- PASS: TestAccAWSStorageGatewayNfsFileShare_NFSFileShareDefaults (300.86s) --- PASS: TestAccAWSStorageGatewayNfsFileShare_ObjectACL (301.34s) --- PASS: TestAccAWSStorageGatewayNfsFileShare_DefaultStorageClass (303.72s) --- PASS: TestAccAWSStorageGatewayNfsFileShare_ReadOnly (313.27s) --- PASS: TestAccAWSStorageGatewayNfsFileShare_RequesterPays (314.76s) --- PASS: TestAccAWSStorageGatewayNfsFileShare_Squash (322.86s) --- PASS: TestAccAWSStorageGatewayNfsFileShare_ClientList (338.09s) --- PASS: TestAccAWSStorageGatewayNfsFileShare_KMSKeyArn (348.13s) --- PASS: TestAccAWSStorageGatewayNfsFileShare_tags (370.05s) ```
Configuration menu - View commit details
-
Copy full SHA for 1902512 - Browse repository at this point
Copy the full SHA 1902512View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6287b73 - Browse repository at this point
Copy the full SHA 6287b73View commit details -
Add Tag Support to API Gateway Domain Name Resource (#10567)
Output from acceptance testing: ``` --- PASS: TestAccAWSAPIGatewayDomainName_SecurityPolicy (19.30s) --- PASS: TestAccAWSAPIGatewayDomainName_Tags (106.29s) --- PASS: TestAccAWSAPIGatewayDomainName_RegionalCertificateArn (113.13s) ```
Configuration menu - View commit details
-
Copy full SHA for a91ad54 - Browse repository at this point
Copy the full SHA a91ad54View commit details -
Configuration menu - View commit details
-
Copy full SHA for 033c2be - Browse repository at this point
Copy the full SHA 033c2beView commit details -
Output from acceptance testing: ``` --- PASS: TestAccDataSourceAWSRDSCluster_basic (134.99s) ```
Configuration menu - View commit details
-
Copy full SHA for 3d37901 - Browse repository at this point
Copy the full SHA 3d37901View commit details -
Add Tag Support to API Gateway API Key Resource (#10568)
Output from acceptance testing: ``` --- PASS: TestAccAWSAPIGatewayApiKey_Value (8.40s) --- PASS: TestAccAWSAPIGatewayApiKey_basic (8.70s) --- PASS: TestAccAWSAPIGatewayApiKey_Enabled (13.28s) --- PASS: TestAccAWSAPIGatewayApiKey_Description (13.78s) --- PASS: TestAccAWSAPIGatewayApiKey_Tags (18.67s) ```
Configuration menu - View commit details
-
Copy full SHA for 07e304c - Browse repository at this point
Copy the full SHA 07e304cView commit details -
Configuration menu - View commit details
-
Copy full SHA for eb8340f - Browse repository at this point
Copy the full SHA eb8340fView commit details -
data acmpa use keyvaluetags (#10725)
Output from acceptance testing: ``` --- PASS: TestAccDataSourceAwsAcmpcaCertificateAuthority_Basic (11.41s) ```
Configuration menu - View commit details
-
Copy full SHA for 455d139 - Browse repository at this point
Copy the full SHA 455d139View commit details -
Merge branch 'add_iotevents_in_hashibothcl' of https:/qui…
…ntagroup/terraform-provider-aws into quintagroup-add_iotevents_in_hashibothcl
Configuration menu - View commit details
-
Copy full SHA for 0660d28 - Browse repository at this point
Copy the full SHA 0660d28View commit details -
provider: Merge related #10593 and #10594 additions for iotanalytics …
…and iotevents labeling
Configuration menu - View commit details
-
Copy full SHA for 4b640c0 - Browse repository at this point
Copy the full SHA 4b640c0View commit details -
Configuration menu - View commit details
-
Copy full SHA for b2763b0 - Browse repository at this point
Copy the full SHA b2763b0View commit details