Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: calcite-pick-list - should not focus or fire event (space bar) on disabled pick-list-item #1478

Closed
AdelheidF opened this issue Jan 26, 2021 · 4 comments
Closed

Bug: calcite-pick-list - should not focus or fire event (space bar) on disabled pick-list-item #1478

AdelheidF opened this issue Jan 26, 2021 · 4 comments
Assignees
@benelan
Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug.
Milestone
Sprint 02/28 - 03/11

Comments

@AdelheidF
Copy link

AdelheidF commented Jan 26, 2021 •
edited
Loading

Summary

(1) When tabbing through a pick-list it sets the focus on the title and then the end-action of an active pick-list-item, this is fine. If a pick-list-item is disabled it still sets the focus on the title. It should not do this, correct? It skips over the end-action of the disabled pick-list-item.

image

Actual Behavior

Expected Behavior

Reproduction Steps

Relevant Info

@AdelheidF AdelheidF added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. labels Jan 26, 2021
@AdelheidF
Copy link
Author

AdelheidF commented Jan 27, 2021 •
edited
Loading

(2) Actually it's more than just the focus. If I click with the mouse on a disabled pick-list-item nothing happens, this is good. If I hit the space bar on a disabled pick-list-item it gets selected. It calls the "calciteListChange" event handler.

@AdelheidF AdelheidF changed the title Bug: calcite-pick-list - should not focus on disabled pick-list-item Bug: calcite-pick-list - should not focus or fire event (space bar) on disabled pick-list-item Jan 27, 2021
@julio8a julio8a added this to the Backlog milestone Jul 16, 2021
@jcfranco jcfranco modified the milestones: Freezer, Back burner Aug 12, 2021
@jcfranco jcfranco added the help wanted Issues that the core team needs help with in a sprint. label Aug 12, 2021
@jcfranco jcfranco mentioned this issue Dec 31, 2021
Closed
3 tasks
@jcfranco jcfranco self-assigned this Dec 31, 2021
@Elijbet Elijbet added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels Jan 19, 2022
@jcfranco
Copy link
Member

Fixed via #2655.

@jcfranco jcfranco added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed help wanted Issues that the core team needs help with in a sprint. 1 - assigned Issues that are assigned to a sprint and a team member. labels Mar 11, 2022
@github-actions
Copy link
Contributor

Installed and assigned for verification.

@AdelheidF
Copy link
Author

Looks good, I can no longer focus the disabled list items. Tested with 1.0.0-next.415

@AdelheidF AdelheidF added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benelan benelan

Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug.
Projects
None yet
Milestone
Sprint 02/28 - 03/11
Development

No branches or pull requests
5 participants
@jcfranco @julio8a @benelan @Elijbet @AdelheidF