Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Epic: consistent disabled prop behavior #2655

Closed
3 tasks done
jcfranco opened this issue Jul 27, 2021 · 7 comments
Closed
3 tasks done

Epic: consistent disabled prop behavior #2655

jcfranco opened this issue Jul 27, 2021 · 7 comments
Assignees
Labels
4 - verified Issues that have been released and confirmed resolved. epic Large scale issues to be broken up into sub-issues and tracked via sprints and/or project.

Comments

@jcfranco
Copy link
Member

jcfranco commented Jul 27, 2021

#2582 surfaced an issue where some of our components may not be implementing disabled appropriately. This epic should help us ensure all components implement this property correctly and prevent keyboard/pointer interaction with the element as well as its children (if applicable).

Action plan

Questions

  • Should all components have a disabled prop or only interactive ones?
    • Answer: only interactive ones

Related issues

@jcfranco jcfranco added the epic Large scale issues to be broken up into sub-issues and tracked via sprints and/or project. label Jul 27, 2021
@jcfranco
Copy link
Member Author

Should all components have a disabled prop or only interactive ones?

@Esri/calcite-design-representatives can you chime in on this one?

@caripizza
Copy link
Contributor

Should all components have a disabled prop or only interactive ones?

IMO only interactive components should have a disabled prop. (ie., disabled prop is used to prevent interaction or communicate that an action is unavailable to the user.)

Maybe all we need to ask is does the component need to prevent interaction?

@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the Stale Issues or pull requests that have not had recent activity. label Aug 28, 2021
@jcfranco jcfranco removed the Stale Issues or pull requests that have not had recent activity. label Aug 30, 2021
@jcfranco jcfranco added this to the Sprint 9/27 – 10/8 milestone Sep 22, 2021
@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the Stale Issues or pull requests that have not had recent activity. label Nov 11, 2021
@github-actions
Copy link
Contributor

This issue has been automatically closed due to inactivity.

@jcfranco jcfranco reopened this Nov 19, 2021
@jcfranco jcfranco removed the Stale Issues or pull requests that have not had recent activity. label Nov 19, 2021
@jcfranco jcfranco self-assigned this Nov 19, 2021
@jcfranco jcfranco added the 2 - in development Issues that are actively being worked on. label Dec 28, 2021
@jcfranco jcfranco added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Mar 9, 2022
@github-actions github-actions bot assigned benelan and unassigned jcfranco Mar 9, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2022

Installed and assigned for verification.

@benelan
Copy link
Member

benelan commented Mar 18, 2022

verified on beta.80
https://codepen.io/benesri/pen/vYpGgKz?editors=1000

@benelan benelan closed this as completed Mar 18, 2022
@benelan benelan added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 - verified Issues that have been released and confirmed resolved. epic Large scale issues to be broken up into sub-issues and tracked via sprints and/or project.
Projects
None yet
Development

No branches or pull requests

3 participants