Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tooling: global test utility for focused components when disabled/loading #2532

Closed
driskull opened this issue Jul 13, 2021 · 2 comments
Closed

Tooling: global test utility for focused components when disabled/loading #2532

driskull opened this issue Jul 13, 2021 · 2 comments
Labels
0 - new New issues that need assignment. calcite-components Issues specific to the @esri/calcite-components package. estimate - 3 A day or two of work, likely requires updates to tests. p - low Issue is non core or affecting less that 10% of people using the library testing Issues related to automated or manual testing. tooling Issues relating to build system fixes or improvements.
Milestone
Freezer

Comments

@driskull
Copy link
Member

Summary

I've noticed a few "control" components that when disabled, they can still be focusable. For example, you can still tab to a disabled calcite-input element and hit enter on it.

#2378 (comment)

Measure of Success

We should setup a global test to test any component that has a disabled or loading property to make sure that it cannot be tabbed to nor any of its child elements can be tabbed into.

If we want to take this one step further, we could make sure that when the components is not disabled or loading, only 1 element within the component is focusable at a time. That might be out of scope for this test though.

Resources

#2378
@driskull driskull added tooling Issues relating to build system fixes or improvements. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Jul 13, 2021
@jcfranco jcfranco added this to the Backlog milestone Jul 15, 2021
@jcfranco jcfranco mentioned this issue Jul 27, 2021
Closed
3 tasks
@jcfranco jcfranco removed the needs triage Planning workflow - pending design/dev review. label Aug 11, 2021
@alisonailea alisonailea changed the title Tooling: global test utility for focused components when disabled/loading. Tooling: global test utility for focused components when disabled/loading Feb 28, 2023
@alisonailea alisonailea modified the milestone: Freezer Feb 28, 2023
@jcfranco jcfranco added estimate - 3 A day or two of work, likely requires updates to tests. p - low Issue is non core or affecting less that 10% of people using the library testing Issues related to automated or manual testing. calcite-components Issues specific to the @esri/calcite-components package. labels Aug 17, 2023
@jcfranco
Copy link
Member

The disabled test helper already covers tabbing when disabled. Currently, loading doesn't set disabled, so we can't reliably test for this yet.

@jcfranco
Copy link
Member

Currently, loading doesn't set disabled, so we can't reliably test for this yet.

We decided to separate loading and disabled at 2.0.0 (see #8292), so this no longer holds.

Closing since the disabled test helper covers focusing via keyboard and mouse when disabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 - new New issues that need assignment. calcite-components Issues specific to the @esri/calcite-components package. estimate - 3 A day or two of work, likely requires updates to tests. p - low Issue is non core or affecting less that 10% of people using the library testing Issues related to automated or manual testing. tooling Issues relating to build system fixes or improvements.
Projects
None yet
Milestone
Freezer
Development

No branches or pull requests
3 participants
@jcfranco @driskull @alisonailea