Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: disabled calcite-input + type=number allows interaction with the up/down buttons. #2582

Closed
1 of 2 tasks
jcfranco opened this issue Jul 20, 2021 · 2 comments
Closed
1 of 2 tasks

Bug: disabled calcite-input + type=number allows interaction with the up/down buttons. #2582

jcfranco opened this issue Jul 20, 2021 · 2 comments
Assignees
@julio8a
Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. good first issue Issues that can be worked on by contributors new to calcite-components. help wanted Issues that the core team needs help with in a sprint.
Milestone
Sprint 7/19 – 7/30

Comments

@jcfranco
Copy link
Member

Actual Behavior

The up/down buttons can be still be clicked when the input component is disabled.

Expected Behavior

Value cannot be adjusted when clicking up/down buttons.

Reproduction Steps or Sample

  1. Open https://codepen.io/jcfranco/pen/XWRaqYW
  2. Click on up/down buttons

Relevant Info

Version: @esri/calcite-components@<version>

  • CDN
  • NPM package
@jcfranco jcfranco added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. help wanted Issues that the core team needs help with in a sprint. good first issue Issues that can be worked on by contributors new to calcite-components. 0 - new New issues that need assignment. labels Jul 20, 2021
@jcfranco jcfranco added this to the Sprint 7/19 – 7/30 milestone Jul 20, 2021
@caripizza
Copy link
Contributor

Related: #2378

@driskull driskull self-assigned this Jul 22, 2021
driskull added a commit that referenced this issue Jul 22, 2021
@driskull
fix(input): disabled calcite-input + type=number allows interaction w…
c704026 
…ith the up/down buttons. #2582
@driskull driskull mentioned this issue Jul 22, 2021
Merged
driskull added a commit that referenced this issue Jul 23, 2021
@driskull
fix(input): disabled calcite-input + type=number allows interaction w…
7249cad 
…ith the up/down buttons (#2609)

* fix(input): disabled calcite-input + type=number allows interaction with the up/down buttons. #2582

* add test
@driskull driskull added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 0 - new New issues that need assignment. labels Jul 23, 2021
@driskull driskull assigned jcfranco and unassigned driskull Jul 23, 2021
@driskull driskull mentioned this issue Jul 23, 2021
Closed
2 tasks
@jcfranco jcfranco mentioned this issue Jul 27, 2021
Closed
3 tasks
@julio8a julio8a assigned julio8a and unassigned jcfranco Jul 27, 2021
@julio8a julio8a added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Jul 27, 2021
@julio8a
Copy link

julio8a commented Jul 27, 2021

verified on Codepen.

@julio8a julio8a closed this as completed Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@julio8a julio8a

Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. good first issue Issues that can be worked on by contributors new to calcite-components. help wanted Issues that the core team needs help with in a sprint.
Projects
None yet
Milestone
Sprint 7/19 – 7/30
Development

No branches or pull requests
4 participants
@jcfranco @driskull @julio8a @caripizza