Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: calcite-fab: click event fires even when its disabled #3226

Closed
2 tasks
kevindoshier opened this issue Oct 13, 2021 · 5 comments
Closed
2 tasks

Bug: calcite-fab: click event fires even when its disabled #3226

kevindoshier opened this issue Oct 13, 2021 · 5 comments
Assignees
@benelan
Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug.
Milestone
Sprint 02/28 - 03/11

Comments

@kevindoshier
Copy link
Contributor

calcite-fab will fire the click event even when its disabled, a calcite-button correctly does not

Actual Behavior

Expected Behavior

It should not fire the click event, in the sample below I place both the fab and a button, disable both, and the button does not fire the event

Reproduction Steps and Sample

Sample:

1.https://codepen.io/kevindoshier/pen/bGrdQrp

Relevant Info

Version: @esri/calcite-components@<version>

  • CDN
  • NPM package
@kevindoshier kevindoshier added 0 - new New issues that need assignment. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review. labels Oct 13, 2021
@CodeBarker
Copy link

CodeBarker commented Oct 14, 2021 •
edited
Loading

This is needed for the December update in Online

@jcfranco jcfranco self-assigned this Oct 20, 2021
@jcfranco jcfranco removed the needs triage Planning workflow - pending design/dev review. label Oct 20, 2021
@jcfranco jcfranco added this to the Sprint 10/25 - 11/5 milestone Oct 20, 2021
@jcfranco
Copy link
Member

This should be addressed by #2655

@jcfranco jcfranco added 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. labels Dec 28, 2021
@jcfranco jcfranco mentioned this issue Dec 31, 2021
Closed
3 tasks
@jcfranco
Copy link
Member

Fixed via #2655.

BTW, the original codepen seems to have been modified for another bug, so I created this one for testing: https://codepen.io/jcfranco/pen/XWVrZqy

@jcfranco jcfranco added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Mar 11, 2022
@github-actions github-actions bot assigned benelan and unassigned jcfranco Mar 11, 2022
@github-actions
Copy link
Contributor

Installed and assigned for verification.

@benelan
Copy link
Member

benelan commented Mar 16, 2022

verified in beta.79

@benelan benelan closed this as completed Mar 16, 2022
@benelan benelan added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benelan benelan

Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug.
Projects
None yet
Milestone
Sprint 02/28 - 03/11
Development

No branches or pull requests
4 participants
@jcfranco @CodeBarker @benelan @kevindoshier