Skip to content
This repository has been archived by the owner on May 23, 2024. It is now read-only.

clean up queryEdgePredicates return values and their use in call site #131

Closed
balhoff opened this issue Nov 17, 2020 · 2 comments
Closed

clean up queryEdgePredicates return values and their use in call site #131

balhoff opened this issue Nov 17, 2020 · 2 comments
Assignees
@jdr0887

Comments

@balhoff
Copy link
Contributor

balhoff commented Nov 17, 2020

I think the values are not really needed in their current structure; it's working but something got garbled in refactoring.
jdr0887 added a commit that referenced this issue Nov 18, 2020
@jdr0887
cleaning up queryEdgePredicates related to issue #131
7e9bad0
@jdr0887
Copy link
Collaborator

jdr0887 commented Nov 18, 2020

I ran the tests after making this change and noticed that wormbase in our prefixes doesn't match that of the database. Found "http://identifiers.org/wormbase/WBGene00000245", but should be "https://www.wormbase.org/get?name=WBGene00000245", right?

@jdr0887 jdr0887 mentioned this issue Nov 18, 2020
Merged
@balhoff
Copy link
Contributor Author

balhoff commented Nov 18, 2020

Thanks, I made an issue here: biolink/biolink-model#530

@balhoff balhoff closed this as completed Nov 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jdr0887 jdr0887

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@balhoff @jdr0887