Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WormBase prefix expansion #530

Closed
balhoff opened this issue Nov 18, 2020 · 8 comments
Closed

WormBase prefix expansion #530

balhoff opened this issue Nov 18, 2020 · 8 comments

Comments

@balhoff
Copy link
Contributor

balhoff commented Nov 18, 2020

Biolink has this expansion for Wormbase:

"WormBase": "https://www.wormbase.org/get?name=",

GO is using http://identifiers.org/wormbase/ in the NEO ontology (and so in GO-CAMs). It would be good to align these. @cmungall which is preferred?

@RichardBruskiewich
Copy link
Contributor

RichardBruskiewich commented Nov 21, 2020

@balhoff @cmungall...

Actually, the currently registered URI from identifiers.org for wormbase is: https://identifiers.org/wb/.

This resolves properly to the wormbase site, e.g. try https://identifiers.org/wb/WBGene00000001 whereas the GO version http://identifiers.org/wormbase/WBGene00000001 doesn't work (anymore.. perhaps it did years ago?).

The current version in the Biolink Model context.jsonld (https://www.wormbase.org/get?name=WBGene00000001) also appears to resolve but seems to originate from one of the default_curi_maps since it is not listed under the model yaml prefixes section.

@RichardBruskiewich
Copy link
Contributor

RichardBruskiewich commented Nov 25, 2020

I'm going to set the WormBase: prefix to the identifiers.org resolved URI, https://identifiers.org/wb/, OK?

We don't have much influence over what other external resources are using (e.g. GO). Somebody else will need to poke them to update their prefix to URI mapping. BTW, this includes the Monarch default_curi_map entry, which is the source of the Wormbase URI in Biolink... I issued a PR prefixcommons/biocontext#32 for this change.

@cmungall
Copy link
Collaborator

cmungall commented Nov 25, 2020 via email

@RichardBruskiewich
Copy link
Contributor

none of the URIs we use should ever have '?'s or query parameters in them!

Yep. Totally agree @cmungall and @balhoff. However, since the Monarch PrefixCommons entry for WormBase had that deficiency, note that I've posted a PR request to fix the URI to the Identifiers.org version (see PR prefixcommons/biocontext#32).

@kshefchek
Copy link
Contributor

kshefchek commented Nov 25, 2020

My understanding is the default_curi_maps section of the biolink model works as a priority list, so the idot_context overrides the monarch context file, is this not the behavior we're seeing?

@deepakunni3
Copy link
Member

@kshefchek Thanks for pointing that out. I wonder how the ordering is. Perhaps the idot_context gets overridden by monarch context.

Will have to look at how biolinkml parses the default_curi_maps directive

@cmungall
Copy link
Collaborator

cmungall commented Nov 25, 2020 via email

@RichardBruskiewich
Copy link
Contributor

RichardBruskiewich commented Nov 25, 2020

@cmungall, @kshefchek @deepakunni3

I certainly stirred a tempest in a teapot here!

I issued the correct PR at monarch-initiative/dipper#1000
I cancelled the PR at prefixcommons/biocontext#32
I removed the WormBase prefix under prefixes of the Biolink YAML in this master commit: a525c53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants