Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small bug fixes for shields #6445

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

Small bug fixes for shields #6445

wants to merge 6 commits into from
+29 −17

Conversation

lL1l1
Copy link
Contributor

@lL1l1 lL1l1 commented Sep 12, 2024 •
edited
Loading

Description of the proposed changes

  • Fix overcharge dealing half damage to shields. Reported on Discord.
  • Prevent tree effect damage from going through shields
  • Move anti-shield area damage before the normal area damage so that the normal damage can overkill things under the shield if the anti-shield damage kills the shield.

Testing done on the proposed changes

Shooting overcharge at a shield in a forest and checking its HP and that the trees on the other side don't get knocked down.

Checklist

  • Changes are annotated, including comments where useful
  • Changes are documented in the changelog for the next game version

@lL1l1
Make shields absorb tree damage fully
52a2e4a 
prevents knocking down/igniting trees under the shield
@lL1l1
Apply anti-shield area damage before normal damage
aaa6270 
Better order allows normal damage to overkill under the shield if the anti-shield damage takes out the shield
@lL1l1
Fix overcharge dealing half damage to shields
b07e9b4
@lL1l1 lL1l1 added type: bug area: sim Area that is affected by the Simulation of the Game labels Sep 12, 2024
BlackYps
BlackYps requested changes Sep 22, 2024
View reviewed changes
Copy link
Contributor

@BlackYps BlackYps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the slip in the comments it looks good. Also tested it and it works

lua/shield.lua Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BlackYps BlackYps BlackYps requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
area: sim Area that is affected by the Simulation of the Game type: bug
Projects
None yet
Milestone
Development iteration III of 2024
Development

Successfully merging this pull request may close these issues.
2 participants
@lL1l1 @BlackYps