Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement basic gesture detection to delete commands #6470

Draft
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

Garanas
Copy link
Member

@Garanas Garanas commented Oct 3, 2024

Description of the proposed changes

Adds a basic gesture detection to allow you to delete commands while in command mode. This is in particular useful when you do not use hotkeys. Often I find myself in the situation that I miss placed a build order. When you do not use hotkeys, this looks like:

  • (0) Miss click a build order.
  • (1) Right click to cancel command mode.
  • (2) Right click to remove the build order.
  • (3) Move mouse to the correct build icon and left-click it.

In particular, step 3 can be time consuming. With this feature it can be simplified to:

  • (0) Miss click a build order.
  • (1) Rage-move the mouse across the build order until it disappears.

And problem solved. See it also in action:

gesture-detection.mp4

Testing done on the proposed changes

All is tested during development. All the code is annotated. Debugging is in particular trivial since it requires no reloading of the game - see also the nice trick with using OnDirty and OnReload of the module 😃 !

Additional context

Requires FAForever/FA-Binary-Patches#90, which is available on the FAF Develop game type. To test this pull request you'll need to start a lobby using the FAF Develop game type to retrieve the correct executable.

With thanks to @4z0t for his time and effort.

Checklist

  • Changes are annotated, including comments where useful
  • Changes are documented in the changelog for the next game version

@Garanas Garanas added the area: ui Anything to do with the User Interface of the Game label Oct 3, 2024
@github-actions github-actions bot marked this pull request as draft October 3, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: ui Anything to do with the User Interface of the Game
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant