New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add error catch for multiple pending payments for single hash #2320

Merged

vindard merged 1 commit into main from add-error-for-mult-pending-payment

Feb 15, 2023

Contributor

vindard commented Feb 13, 2023 •

edited

Loading

Description

See #2151, there are some critical assumptions that depend on there being only 1 pending payment for a payment hash at any given time:

having only 1 ledger transaction be debited for user for a single lnd payment (failure mode is user gets over-debited)
accounting for fees correctly if a route changes and fees increase in lnd payment out


chore: add error catch for multiple pending payments for single hash

1d8f4bb

vindard requested a review from dolcalmi

February 13, 2023 21:41

dolcalmi approved these changes

View reviewed changes

vindard merged commit 0e362b4 into main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment