chore: add error catch for multiple pending payments for single hash

src/app/payments/update-pending-payments.ts

@@ -5,6 +5,7 @@ import {
  CouldNotFindTransactionError,
  inputAmountFromLedgerTransaction,
  LedgerTransactionType,
+ MultiplePendingPaymentsForHashError,
  UnknownLedgerError,
 } from "@domain/ledger"
 import { MissingPropsInTransactionForPaymentFlowError } from "@domain/payments"
@@ -281,8 +282,16 @@ const reconstructPendingPaymentFlow = async <
  ? tx.satsAmount === inputAmount
  : tx.centsAmount === inputAmount,
  )
- if (!(filteredPayments && filteredPayments.length))
+ if (!(filteredPayments && filteredPayments.length)) {
  return new CouldNotFindTransactionError()
+ }
+ // Note: Assumptions that rely on there being 1 pending payment
+ // - no more than one transaction gets settled for a given single lnd payment
+ // - fees are for the latest lnd payment attempt
+ if (filteredPayments.length !== 1) {
+ return new MultiplePendingPaymentsForHashError()
+ }
+
  const payment = filteredPayments[0]
 
  return PaymentFlowFromLedgerTransaction({

src/domain/ledger/errors.ts

@@ -7,6 +7,9 @@ export class FeeDifferenceError extends LedgerError {}
 export class NoTransactionToSettleError extends LedgerServiceError {}
 export class InvalidPaginationArgumentsError extends LedgerServiceError {}
 export class MismatchedResultForTransactionMetadataQuery extends LedgerServiceError {}
+export class MultiplePendingPaymentsForHashError extends LedgerServiceError {
+ level = ErrorLevel.Critical
+}
 export class UnknownLedgerError extends LedgerServiceError {
  level = ErrorLevel.Critical
 }

src/graphql/error-map.ts

@@ -414,6 +414,7 @@ export const mapError = (error: ApplicationError): CustomApolloError => {
  case "InvalidDocumentIdForDbError":
  case "MismatchedResultForTransactionMetadataQuery":
  case "InvalidLedgerTransactionId":
+ case "MultiplePendingPaymentsForHashError":
  case "CacheError":
  case "CacheNotAvailableError":
  case "CacheServiceError":