Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable currency service metrics #74

Closed

Conversation

damemi
Copy link
Member

@damemi damemi commented May 8, 2024

Metrics from the currency app were filtered due to open-telemetry/opentelemetry-demo#1330, which has been resolved upstream. Re-enabling this now so we can get telemetry from all available services.

@damemi
Copy link
Member Author

damemi commented May 8, 2024

Opening this as a draft for now because I'm still seeing the issue with the currency service in the collector logs:

2024-05-08T19:11:46.314Z	error	exporterhelper/queue_sender.go:125	Exporting failed. No more retries left. Dropping data.	{"kind": "exporter", "data_type": "metrics", "name": "googlemanagedprometheus", "error": "rpc error: code = InvalidArgument desc = One or more TimeSeries could not be written: One or more points were written more frequently than the maximum sampling period configured for the metric.: prometheus_target{namespace:otel-demo,cluster:autopilot-cluster-2,instance:adc2c5ec-7cad-4729-a616-0f21b55ec738,job:opentelemetry-demo/currencyservice,location:us-central1} timeSeries[0-2]: prometheus.googleapis.com/app_currency_counter_total/counter{otel_scope_name:app_currency,otel_scope_version:1.3.0,currency_code:USD}\nerror details: name = Unknown  desc = total_point_count:3  errors:{status:{code:9}  point_count:3}", "dropped_items": 1}

it's pretty noisy, so I don't think we want to merge it in yet. but this will be part of the fix

Copy link

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label May 16, 2024
Copy link

Closed as inactive. Feel free to reopen if this PR is still being worked on.

@github-actions github-actions bot closed this May 24, 2024
@damemi damemi reopened this May 28, 2024
@damemi damemi closed this May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant